Skip to content

Commit 49ed9a2

Browse files
alan-agius4clydin
authored andcommitted
fix(@angular-devkit/build-angular): emit error when using prerender and app-shell builders with application builder
The application builder has built-in prerendering and app-shell generation capabilities which makes using these builders redundant.
1 parent 140a5f5 commit 49ed9a2

File tree

2 files changed

+20
-0
lines changed
  • packages/angular_devkit/build_angular/src/builders

2 files changed

+20
-0
lines changed

packages/angular_devkit/build_angular/src/builders/app-shell/index.ts

+10
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,16 @@ async function _appShellBuilder(
178178
serviceWorker: false,
179179
optimization: optimization as unknown as JsonObject,
180180
});
181+
182+
if (browserTargetRun.info.builderName === '@angular-devkit/build-angular:application') {
183+
return {
184+
success: false,
185+
error:
186+
'"@angular-devkit/build-angular:application" has built-in app-shell generation capabilities. ' +
187+
'The "appShell" option should be used instead.',
188+
};
189+
}
190+
181191
const serverTargetRun = await context.scheduleTarget(serverTarget, {
182192
watch: false,
183193
});

packages/angular_devkit/build_angular/src/builders/prerender/index.ts

+10
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,16 @@ async function _scheduleBuilds(
106106
serviceWorker: false,
107107
// todo: handle service worker augmentation
108108
});
109+
110+
if (browserTargetRun.info.builderName === '@angular-devkit/build-angular:application') {
111+
return {
112+
success: false,
113+
error:
114+
'"@angular-devkit/build-angular:application" has built-in prerendering capabilities. ' +
115+
'The "prerender" option should be used instead.',
116+
};
117+
}
118+
109119
const serverTargetRun = await context.scheduleTarget(serverTarget, {
110120
watch: false,
111121
});

0 commit comments

Comments
 (0)