fix(@angular-devkit/schematics): fix __dasherize__ name

Sometimes, some actions are not properly optimized. I havent had time to fully
investigate, and we will rework the ActionList entirely (making it more solid
and in line with the rest of the pipeline), so this error will move away properly.
In the meantime, when creating a source, optimizing the tree early helps
tremendously, and since it is not merged (and built from an empty tree),
there is no side effect to optimizing.

Author: hansl

packages/angular_devkit/schematics/src/rules/base.ts

@@ -14,6 +14,7 @@ import {
   branch,
   empty as staticEmpty,
   merge as staticMerge,
+  optimize as staticOptimize,
   partition as staticPartition,
 } from '../tree/static';
 import { VirtualTree } from '../tree/virtual';
@@ -53,7 +54,22 @@ export function chain(rules: Rule[]): Rule {
  */
 export function apply(source: Source, rules: Rule[]): Source {
   return (context: SchematicContext) => {
-    return callRule(chain(rules), callSource(source, context), context);
+    return callRule(chain([
+      ...rules,
+      // Optimize the tree. Since this is a source tree, there's not much harm here and this might
+      // avoid further issues.
+      tree => {
+        if (tree instanceof VirtualTree) {
+          tree.optimize();
+
+          return tree;
+        } else if (tree.actions.length != 0) {
+          return staticOptimize(tree);
+        } else {
+          return tree;
+        }
+      },
+    ]), callSource(source, context), context);
   };
 }
 

packages/schematics/angular/ng-new/index.ts

@@ -60,7 +60,6 @@ export default function (options: NgNewOptions): Rule {
         schematic('workspace', workspaceOptions),
         schematic('application', applicationOptions),
         move(options.directory || options.name),
-        tree => Tree.optimize(tree),
       ]),
     ),
     (host: Tree, context: SchematicContext) => {