Skip to content

Commit 4457e1e

Browse files
committed
Removed ngAppResolve() which had process.cwd() instead of project.root from tests.
1 parent a734c98 commit 4457e1e

File tree

2 files changed

+100
-91
lines changed

2 files changed

+100
-91
lines changed
+88-87
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,93 @@
11
import * as webpack from 'webpack';
2-
import {ngAppResolve} from './webpack-build-utils';
32

43
const path = require('path');
54

6-
export const webpackTestConfig = {
7-
devtool: 'inline-source-map',
8-
context: path.resolve(__dirname, './'),
9-
resolve: {
10-
extensions: ['', '.ts', '.js'],
11-
root: ngAppResolve('./src')
12-
},
13-
entry: {
14-
test: ngAppResolve('./src/test.ts')
15-
},
16-
output: {
17-
path: './dist.test',
18-
filename: '[name].bundle.js'
19-
},
20-
module: {
21-
preLoaders: [
22-
{
23-
test: /\.ts$/,
24-
loader: 'tslint-loader',
25-
exclude: [
26-
ngAppResolve('node_modules')
27-
]
28-
},
29-
{
30-
test: /\.js$/,
31-
loader: 'source-map-loader',
32-
exclude: [
33-
ngAppResolve('node_modules/rxjs'),
34-
ngAppResolve('node_modules/@angular')
35-
]
36-
}
37-
],
38-
loaders: [
39-
{
40-
test: /\.ts$/,
41-
loaders: [
42-
{
43-
loader: 'awesome-typescript-loader',
44-
query: {
45-
useWebpackText: true,
46-
tsconfig: ngAppResolve('./src/tsconfig.json'),
47-
// resolveGlobs: false,
48-
module: "commonjs",
49-
target: "es5",
50-
lib: ['es6', 'dom'],
51-
useForkChecker: true,
52-
removeComments: true
5+
export const getWebpackTestConfig = function(projectRoot: string) {
6+
return {
7+
devtool: 'inline-source-map',
8+
context: path.resolve(__dirname, './'),
9+
resolve: {
10+
extensions: ['', '.ts', '.js'],
11+
root: path.resolve(projectRoot, './src')
12+
},
13+
entry: {
14+
test: path.resolve(projectRoot, './src/test.ts')
15+
},
16+
output: {
17+
path: './dist.test',
18+
filename: '[name].bundle.js'
19+
},
20+
module: {
21+
preLoaders: [
22+
{
23+
test: /\.ts$/,
24+
loader: 'tslint-loader',
25+
exclude: [
26+
path.resolve(projectRoot, 'node_modules')
27+
]
28+
},
29+
{
30+
test: /\.js$/,
31+
loader: 'source-map-loader',
32+
exclude: [
33+
path.resolve(projectRoot, 'node_modules/rxjs'),
34+
path.resolve(projectRoot, 'node_modules/@angular')
35+
]
36+
}
37+
],
38+
loaders: [
39+
{
40+
test: /\.ts$/,
41+
loaders: [
42+
{
43+
loader: 'awesome-typescript-loader',
44+
query: {
45+
useWebpackText: true,
46+
tsconfig: path.resolve(projectRoot, './src/tsconfig.json'),
47+
// resolveGlobs: false,
48+
module: "commonjs",
49+
target: "es5",
50+
lib: ['es6', 'dom'],
51+
useForkChecker: true,
52+
removeComments: true
53+
}
54+
},
55+
{
56+
loader: 'angular2-template-loader'
5357
}
54-
},
55-
{
56-
loader: 'angular2-template-loader'
57-
}
58-
],
59-
exclude: [/\.e2e\.ts$/]
60-
},
61-
{ test: /\.json$/, loader: 'json-loader'},
62-
{ test: /\.css$/, loaders: ['raw-loader', 'postcss-loader'] },
63-
{ test: /\.styl$/, loaders: ['raw-loader', 'postcss-loader', 'stylus-loader'] },
64-
{ test: /\.less$/, loaders: ['raw-loader', 'postcss-loader', 'less-loader'] },
65-
{ test: /\.scss$/, loaders: ['raw-loader', 'postcss-loader', 'sass-loader'] },
66-
{ test: /\.(jpg|png)$/, loader: 'url-loader?limit=128000'},
67-
{ test: /\.html$/, loader: 'raw-loader', exclude: [ngAppResolve('src/index.html')] }
68-
],
69-
postLoaders: [
70-
{
71-
test: /\.(js|ts)$/, loader: 'istanbul-instrumenter-loader',
72-
exclude: [
73-
/\.(e2e|spec)\.ts$/,
74-
/node_modules/
75-
]
76-
}
77-
]
78-
},
79-
tslint: {
80-
emitErrors: false,
81-
failOnHint: false,
82-
resourcePath: 'src'
83-
},
84-
node: {
85-
global: 'window',
86-
process: false,
87-
crypto: 'empty',
88-
module: false,
89-
clearImmediate: false,
90-
setImmediate: false
91-
}
92-
};
58+
],
59+
exclude: [/\.e2e\.ts$/]
60+
},
61+
{ test: /\.json$/, loader: 'json-loader'},
62+
{ test: /\.css$/, loaders: ['raw-loader', 'postcss-loader'] },
63+
{ test: /\.styl$/, loaders: ['raw-loader', 'postcss-loader', 'stylus-loader'] },
64+
{ test: /\.less$/, loaders: ['raw-loader', 'postcss-loader', 'less-loader'] },
65+
{ test: /\.scss$/, loaders: ['raw-loader', 'postcss-loader', 'sass-loader'] },
66+
{ test: /\.(jpg|png)$/, loader: 'url-loader?limit=128000'},
67+
{ test: /\.html$/, loader: 'raw-loader', exclude: [path.resolve(projectRoot, 'src/index.html')] }
68+
],
69+
postLoaders: [
70+
{
71+
test: /\.(js|ts)$/, loader: 'istanbul-instrumenter-loader',
72+
exclude: [
73+
/\.(e2e|spec)\.ts$/,
74+
/node_modules/
75+
]
76+
}
77+
]
78+
},
79+
tslint: {
80+
emitErrors: false,
81+
failOnHint: false,
82+
resourcePath: 'src'
83+
},
84+
node: {
85+
global: 'window',
86+
process: false,
87+
crypto: 'empty',
88+
module: false,
89+
clearImmediate: false,
90+
setImmediate: false
91+
}
92+
};
93+
}

addon/ng2/tasks/test.js

+12-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var Promise = require('ember-cli/lib/ext/promise');
55
var Task = require('ember-cli/lib/models/task');
66
var path = require('path');
77
var ngAppResolve = require('../models').ngAppResolve;
8-
var webpackTestConfig = require('../models').webpackTestConfig;
8+
var webpackTestConfig = require('../models/webpack-build-test').getWebpackTestConfig;
99
var displayOptions = require('../models/webpack-build-utils').webpackOutputOptions;
1010

1111
// require dependencies within the target project
@@ -39,10 +39,18 @@ module.exports = Task.extend({
3939
// Single test entry file. Will run the test.ts bundle and track it.
4040
options.files = [{ pattern: './src/test.ts', watched: false }];
4141
options.preprocessors = { './src/test.ts': ['coverage','webpack','sourcemap'] };
42-
options.webpack = webpackTestConfig;
42+
options.webpack = webpackTestConfig(projectRoot);
4343
options.webpackMiddleware = {
44-
noInfo: true, // Hide webpack output because its noisy
45-
stats: displayOptions // Also prevent chunk and module display output, cleaner look.
44+
noInfo: true, // Hide webpack output because its noisy.
45+
stats: { // Also prevent chunk and module display output, cleaner look. Only emit errors.
46+
assets: false,
47+
colors: true,
48+
version: false,
49+
hash: false,
50+
timings: false,
51+
chunks: false,
52+
chunkModules: false
53+
}
4654
};
4755

4856
// Convert browsers from a string to an array

0 commit comments

Comments
 (0)