Skip to content

Commit 3b39843

Browse files
Meligyfilipesilva
authored andcommitted
fix(@angular/cli): fix e2e after eject
Start webpack-dev-server with e2e & sync its port with protractor default config port. Close #4957
1 parent 48324d1 commit 3b39843

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

packages/@angular/cli/tasks/eject.ts

+8-1
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,12 @@ export default Task.extend({
439439
Your package.json scripts needs to not contain a start script as it will be overwritten.
440440
`);
441441
}
442+
if (scripts['pree2e'] && scripts['prepree2e'] !== 'npm start' && !force) {
443+
throw new SilentError(oneLine`
444+
Your package.json scripts needs to not contain a prepree2e script as it will be
445+
overwritten.
446+
`);
447+
}
442448
if (scripts['pree2e'] && scripts['pree2e'] !== pree2eNpmScript && !force) {
443449
throw new SilentError(oneLine`
444450
Your package.json scripts needs to not contain a pree2e script as it will be
@@ -457,8 +463,9 @@ export default Task.extend({
457463
}
458464

459465
packageJson['scripts']['build'] = 'webpack';
460-
packageJson['scripts']['start'] = 'webpack-dev-server';
466+
packageJson['scripts']['start'] = 'webpack-dev-server --port=4200';
461467
packageJson['scripts']['test'] = 'karma start ./karma.conf.js';
468+
packageJson['scripts']['prepree2e'] = 'npm start';
462469
packageJson['scripts']['pree2e'] = pree2eNpmScript;
463470
packageJson['scripts']['e2e'] = 'protractor ./protractor.conf.js';
464471

0 commit comments

Comments
 (0)