refactor: use .template suffix for all schematic files

Currently when using `ivy-ngcc` it will print out a warning

```
Failed to read entry point info from //node_modules/@schematics/angular/workspace/files/package.json with error SyntaxError: Unexpected token < in JSON at position 1121.
```

Fixes #13378

Author: Alan Agius

packages/schematics/angular/application/files/lint/__tsLintRoot__/tslint.json renamed to packages/schematics/angular/application/files/lint/__tsLintRoot__/tslint.json.template

@@ -21,13 +21,13 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   chain,
   filter,
   mergeWith,
   move,
   noop,
   schematic,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
@@ -292,7 +292,7 @@ function addAppToWorkspaceFile(options: ApplicationOptions, workspace: Workspace
 }
 
 function minimalPathFilter(path: string): boolean {
-  const toRemoveList = /(test.ts|tsconfig.spec.json|karma.conf.js)$/;
+  const toRemoveList = /(test.ts|tsconfig.spec.json|karma.conf.js).template$/;
 
   return !toRemoveList.test(path);
 }
@@ -351,7 +351,7 @@ export default function (options: ApplicationOptions): Rule {
       mergeWith(
         apply(url('./files/src'), [
           options.minimal ? filter(minimalPathFilter) : noop(),
-          template({
+          applyTemplates({
             utils: strings,
             ...options,
             'dot': '.',
@@ -362,7 +362,7 @@ export default function (options: ApplicationOptions): Rule {
       mergeWith(
         apply(url('./files/root'), [
           options.minimal ? filter(minimalPathFilter) : noop(),
-          template({
+          applyTemplates({
             utils: strings,
             ...options,
             'dot': '.',
@@ -374,7 +374,7 @@ export default function (options: ApplicationOptions): Rule {
         ])),
       options.minimal ? noop() : mergeWith(
         apply(url('./files/lint'), [
-          template({
+          applyTemplates({
             utils: strings,
             ...options,
             tsLintRoot,
@@ -406,9 +406,13 @@ export default function (options: ApplicationOptions): Rule {
       }),
       mergeWith(
         apply(url('./other-files'), [
-          componentOptions.inlineTemplate ? filter(path => !path.endsWith('.html')) : noop(),
-          componentOptions.skipTests ? filter(path => !/[.|-]spec.ts$/.test(path)) : noop(),
-          template({
+          componentOptions.inlineTemplate
+            ? filter(path => !path.endsWith('.html.template'))
+            : noop(),
+          componentOptions.skipTests
+            ? filter(path => !/[.|-]spec.ts.template$/.test(path))
+            : noop(),
+          applyTemplates({
             utils: strings,
             ...options as any,  // tslint:disable-line:no-any
             selector: appRootSelector,

packages/schematics/angular/application/files/root/browserslist renamed to packages/schematics/angular/application/files/root/browserslist.template

@@ -12,13 +12,13 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   filter,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { applyLintFix } from '../utility/lint-fix';
@@ -48,8 +48,8 @@ export default function (options: ClassOptions): Rule {
     options.skipTests = options.skipTests || !options.spec;
 
     const templateSource = apply(url('./files'), [
-      options.skipTests ? filter(path => !path.endsWith('.spec.ts')) : noop(),
-      template({
+      options.skipTests ? filter(path => !path.endsWith('.spec.ts.template')) : noop(),
+      applyTemplates({
         ...strings,
         ...options,
       }),

packages/schematics/angular/application/files/root/karma.conf.js renamed to packages/schematics/angular/application/files/root/karma.conf.js.template

@@ -11,13 +11,13 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   filter,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import * as ts from 'typescript';
@@ -154,10 +154,10 @@ export default function (options: ComponentOptions): Rule {
     validateHtmlSelector(options.selector);
 
     const templateSource = apply(url('./files'), [
-      options.skipTests ? filter(path => !path.endsWith('.spec.ts')) : noop(),
-      options.inlineStyle ? filter(path => !path.endsWith('.__style__')) : noop(),
-      options.inlineTemplate ? filter(path => !path.endsWith('.html')) : noop(),
-      template({
+      options.skipTests ? filter(path => !path.endsWith('.spec.ts.template')) : noop(),
+      options.inlineStyle ? filter(path => !path.endsWith('.__style__.template')) : noop(),
+      options.inlineTemplate ? filter(path => !path.endsWith('.html.template')) : noop(),
+      applyTemplates({
         ...strings,
         'if-flat': (s: string) => options.flat ? '' : s,
         ...options,

packages/schematics/angular/application/files/root/tsconfig.app.json renamed to packages/schematics/angular/application/files/root/tsconfig.app.json.template

@@ -11,13 +11,13 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   filter,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import * as ts from 'typescript';
@@ -125,8 +125,8 @@ export default function (options: DirectiveOptions): Rule {
     options.skipTests = options.skipTests || !options.spec;
 
     const templateSource = apply(url('./files'), [
-      options.skipTests ? filter(path => !path.endsWith('.spec.ts')) : noop(),
-      template({
+      options.skipTests ? filter(path => !path.endsWith('.spec.ts.template')) : noop(),
+      applyTemplates({
         ...strings,
         'if-flat': (s: string) => options.flat ? '' : s,
         ...options,

packages/schematics/angular/application/files/root/tsconfig.spec.json renamed to packages/schematics/angular/application/files/root/tsconfig.spec.json.template

@@ -12,10 +12,10 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   chain,
   mergeWith,
   move,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { getWorkspace, updateWorkspace } from '../utility/config';
@@ -127,7 +127,7 @@ export default function (options: E2eOptions): Rule {
       addAppToWorkspaceFile(options, workspace),
       mergeWith(
         apply(url('./files'), [
-          template({
+          applyTemplates({
             utils: strings,
             ...options,
             'dot': '.',

packages/schematics/angular/application/files/src/assets/__dot__gitkeep renamed to packages/schematics/angular/application/files/src/assets/__dot__gitkeep.template

@@ -12,12 +12,12 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { applyLintFix } from '../utility/lint-fix';
@@ -42,7 +42,7 @@ export default function (options: EnumOptions): Rule {
     options.path = parsedPath.path;
 
     const templateSource = apply(url('./files'), [
-      template({
+      applyTemplates({
         ...strings,
         ...options,
       }),

packages/schematics/angular/application/files/src/environments/environment.prod.ts renamed to packages/schematics/angular/application/files/src/environments/environment.prod.ts.template

@@ -11,13 +11,13 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   filter,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { applyLintFix } from '../utility/lint-fix';
@@ -59,8 +59,8 @@ export default function (options: GuardOptions): Rule {
     options.skipTests = options.skipTests || !options.spec;
 
     const templateSource = apply(url('./files'), [
-      options.skipTests ? filter(path => !path.endsWith('.spec.ts')) : noop(),
-      template({
+      options.skipTests ? filter(path => !path.endsWith('.spec.ts.template')) : noop(),
+      applyTemplates({
         implementations,
         implementationImports,
         ...strings,

packages/schematics/angular/application/files/src/environments/environment.ts renamed to packages/schematics/angular/application/files/src/environments/environment.ts.template

@@ -11,12 +11,12 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { applyLintFix } from '../utility/lint-fix';
@@ -44,7 +44,7 @@ export default function (options: InterfaceOptions): Rule {
     options.type = !!options.type ? `.${options.type}` : '';
 
     const templateSource = apply(url('./files'), [
-      template({
+      applyTemplates({
         ...strings,
         ...options,
       }),

packages/schematics/angular/application/files/src/favicon.ico renamed to packages/schematics/angular/application/files/src/favicon.ico.template

@@ -12,12 +12,12 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   mergeWith,
   noop,
   schematic,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
@@ -204,7 +204,7 @@ export default function (options: LibraryOptions): Rule {
     const relativePathToWorkspaceRoot = projectRoot.split('/').map(x => '..').join('/');
 
     const templateSource = apply(url('./files'), [
-      template({
+      applyTemplates({
         ...strings,
         ...options,
         packageName,

packages/schematics/angular/application/files/src/index.html renamed to packages/schematics/angular/application/files/src/index.html.template

@@ -11,13 +11,13 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   filter,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import * as ts from 'typescript';
@@ -89,8 +89,8 @@ export default function (options: ModuleOptions): Rule {
     options.path = parsedPath.path;
 
     const templateSource = apply(url('./files'), [
-      options.routing ? noop() : filter(path => !path.endsWith('-routing.module.ts')),
-      template({
+      options.routing ? noop() : filter(path => !path.endsWith('-routing.module.ts.template')),
+      applyTemplates({
         ...strings,
         'if-flat': (s: string) => options.flat ? '' : s,
         ...options,

packages/schematics/angular/application/files/src/main.ts renamed to packages/schematics/angular/application/files/src/main.ts.template

@@ -11,13 +11,13 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   branchAndMerge,
   chain,
   filter,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import * as ts from 'typescript';
@@ -106,8 +106,8 @@ export default function (options: PipeOptions): Rule {
     options.skipTests = options.skipTests || !options.spec;
 
     const templateSource = apply(url('./files'), [
-      options.skipTests ? filter(path => !path.endsWith('.spec.ts')) : noop(),
-      template({
+      options.skipTests ? filter(path => !path.endsWith('.spec.ts.template')) : noop(),
+      applyTemplates({
         ...strings,
         'if-flat': (s: string) => options.flat ? '' : s,
         ...options,

packages/schematics/angular/application/files/src/polyfills.ts renamed to packages/schematics/angular/application/files/src/polyfills.ts.template

@@ -11,10 +11,10 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   chain,
   mergeWith,
   move,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
@@ -176,7 +176,7 @@ export default function (options: ServiceWorkerOptions): Rule {
 
     const root = project.root || project.sourceRoot || '';
     const templateSource = apply(url('./files'), [
-      template({ ...options, resourcesOutputPath }),
+      applyTemplates({ ...options, resourcesOutputPath }),
       move(root),
     ]);
 

packages/schematics/angular/application/files/src/styles.__style__ renamed to packages/schematics/angular/application/files/src/styles.__style__.template

@@ -11,12 +11,12 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   chain,
   filter,
   mergeWith,
   move,
   noop,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import { applyLintFix } from '../utility/lint-fix';
@@ -43,8 +43,8 @@ export default function (options: ServiceOptions): Rule {
     options.skipTests = options.skipTests || !options.spec;
 
     const templateSource = apply(url('./files'), [
-      options.skipTests ? filter(path => !path.endsWith('.spec.ts')) : noop(),
-      template({
+      options.skipTests ? filter(path => !path.endsWith('.spec.ts.template')) : noop(),
+      applyTemplates({
         ...strings,
         'if-flat': (s: string) => options.flat ? '' : s,
         ...options,

packages/schematics/angular/application/files/src/test.ts renamed to packages/schematics/angular/application/files/src/test.ts.template

@@ -20,10 +20,10 @@ import {
   SchematicsException,
   Tree,
   apply,
+  applyTemplates,
   chain,
   mergeWith,
   move,
-  template,
   url,
 } from '@angular-devkit/schematics';
 import {
@@ -257,7 +257,7 @@ export default function (options: UniversalOptions): Rule {
     }
 
     const templateSource = apply(url('./files/src'), [
-      template({
+      applyTemplates({
         ...strings,
         ...options as object,
         stripTsExtension: (s: string) => s.replace(/\.ts$/, ''),
@@ -266,7 +266,7 @@ export default function (options: UniversalOptions): Rule {
     ]);
 
     const rootSource = apply(url('./files/root'), [
-      template({
+      applyTemplates({
         ...strings,
         ...options as object,
         stripTsExtension: (s: string) => s.replace(/\.ts$/, ''),