Skip to content

Commit 30cc482

Browse files
committed
fix(build): enable chunkhash in inline.js
We had CommonsChunkPlugin misconfigured to remove the chunkhash in inline.js. Partially address #2307 Close #2899
1 parent 0e91dfe commit 30cc482

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

packages/angular-cli/models/webpack-build-common.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,7 @@ export function getWebpackCommonConfig(
107107
}),
108108
new webpack.optimize.CommonsChunkPlugin({
109109
minChunks: Infinity,
110-
name: 'inline',
111-
filename: 'inline.js',
112-
sourceMapFilename: 'inline.map'
110+
name: 'inline'
113111
}),
114112
new GlobCopyWebpackPlugin({
115113
patterns: appConfig.assets,

tests/e2e/tests/third-party/bootstrap.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default function() {
2222
.then(() => expectFileToMatch('dist/scripts.bundle.js', '/*!\\n * Bootstrap'))
2323
.then(() => expectFileToMatch('dist/styles.bundle.js', '/*!\\n * Bootstrap'))
2424
.then(() => expectFileToMatch('dist/index.html', oneLineTrim`
25-
<script type="text/javascript" src="inline.js"></script>
25+
<script type="text/javascript" src="inline.bundle.js"></script>
2626
<script type="text/javascript" src="styles.bundle.js"></script>
2727
<script type="text/javascript" src="scripts.bundle.js"></script>
2828
<script type="text/javascript" src="main.bundle.js"></script>

0 commit comments

Comments
 (0)