Skip to content

Commit 2fc322f

Browse files
filipesilvavikerman
authored andcommitted
fix(@schematics/update): validate all peer dependencies
1 parent 769eea1 commit 2fc322f

File tree

1 file changed

+5
-3
lines changed
  • packages/schematics/update/update

1 file changed

+5
-3
lines changed

packages/schematics/update/update/index.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ function _validateForwardPeerDependencies(
116116
logger: logging.LoggerApi,
117117
next: boolean,
118118
): boolean {
119+
let validationFailed = false;
119120
for (const [peer, range] of Object.entries(peers)) {
120121
logger.debug(`Checking forward peer ${peer}...`);
121122
const maybePeerInfo = infoMap.get(peer);
@@ -125,7 +126,7 @@ function _validateForwardPeerDependencies(
125126
`${JSON.stringify(peer)} @ ${JSON.stringify(range)}.`,
126127
].join(' '));
127128

128-
return false;
129+
continue;
129130
}
130131

131132
const peerVersion = maybePeerInfo.target && maybePeerInfo.target.packageJson.version
@@ -140,11 +141,12 @@ function _validateForwardPeerDependencies(
140141
`would install ${JSON.stringify(peerVersion)})`,
141142
].join(' '));
142143

143-
return true;
144+
validationFailed = true;
145+
continue;
144146
}
145147
}
146148

147-
return false;
149+
return validationFailed;
148150
}
149151

150152

0 commit comments

Comments
 (0)