fix(@angular-devkit/build-angular): limit advanced terser passes to two

clydin · filipesilva · commit 2c2b499193fb · 2021-07-13T15:21:06.000+01:00
Limiting the terser passes to two helps to workaround an issue with terser wherein terser will errantly inline a function argument containing a `yield` expression inside an inner arrow function.  This results in a syntax error since the yield expression is no longer within the scope of a generator.
diff --git a/packages/angular_devkit/build_angular/src/webpack/plugins/javascript-optimizer-worker.ts b/packages/angular_devkit/build_angular/src/webpack/plugins/javascript-optimizer-worker.ts
@@ -93,7 +93,7 @@ async function optimizeWithTerser(
     { [name]: code },
     {
       compress: {
-        passes: advanced ? 3 : 1,
+        passes: advanced ? 2 : 1,
         pure_getters: advanced,
       },
       ecma: target,

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ async function optimizeWithTerser(`
`93`	`93`	`{ [name]: code },`
`94`	`94`	`{`
`95`	`95`	`compress: {`
`96`		`- passes: advanced ? 3 : 1,`
	`96`	`+ passes: advanced ? 2 : 1,`
`97`	`97`	`pure_getters: advanced,`
`98`	`98`	`},`
`99`	`99`	`ecma: target,`