Skip to content

Commit 274c1a4

Browse files
committed
docs: improve feature requests.
1 parent fb96871 commit 274c1a4

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

CONTRIBUTING.md

+12-3
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,21 @@ You can *request* a new feature by [submitting an issue](#submit-issue) to our [
4040
Repository][github]. If you would like to *implement* a new feature, please submit an issue with
4141
a proposal for your work first, to be sure that we can use it. Angular CLI is in developer preview
4242
and we are not ready to accept major contributions ahead of the full release.
43-
Please consider what kind of change it is:
4443

45-
* For a **Major Feature**, first open an issue and outline your proposal so that it can be
44+
First open an issue and outline your proposal so that it can be
4645
discussed. This will also allow us to better coordinate our efforts, prevent duplication of work,
4746
and help you to craft the change so that it is successfully accepted into the project.
48-
* **Small Features** can be crafted and directly [submitted as a Pull Request](#submit-pr).
47+
48+
**All features require a proper design and review by team members.** Before starting work, you might want to
49+
discuss with us to figure out:
50+
51+
* Is this something we want? Sometimes people make feature requests that make sense for them, but aren't valuable
52+
to the rest of the CLI users, or impede on other people's workflow. We try to always put the greater community
53+
first.
54+
* Is the API valid? Does it change currently existing flags, or add new ones?
55+
* What's the impact on the rest of the CLI? Does it affect other commands/flags?
56+
57+
Answering those questions first in the request might help us make a decision.
4958

5059
## <a name="submit"></a> Submission Guidelines
5160

0 commit comments

Comments
 (0)