Skip to content

Commit 233bb7e

Browse files
committed
build: use devkit snapshots for e2e
1 parent f8902a8 commit 233bb7e

File tree

4 files changed

+28
-3
lines changed

4 files changed

+28
-3
lines changed

tests/e2e/setup/015-build.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ export default function() {
1212
return;
1313
}
1414

15-
return npm('run', 'build', '--', '--local', argv.devkit ? '--devkit=' + argv.devkit : undefined)
15+
const devkitArg = argv.devkit ? '--devkit=' + argv.devkit : '--devkit-snapshots';
16+
17+
return npm('run', 'build', '--', '--local', devkitArg)
1618
.then(() => {
1719
if (!argv.nightly && !argv['ng-sha']) {
1820
return;

tests/e2e/setup/500-create-project.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
useCIDefaults,
99
useBuiltPackages,
1010
useDevKit,
11+
useDevKitSnapshots,
1112
updateJsonFile,
1213
} from '../utils/project';
1314
import {gitClean, gitCommit} from '../utils/git';
@@ -32,7 +33,7 @@ export default async function() {
3233

3334
return Promise.resolve()
3435
.then(() => useBuiltPackages())
35-
.then(() => argv.devkit && useDevKit(argv.devkit))
36+
.then(() => argv.devkit ? useDevKit(argv.devkit) : useDevKitSnapshots())
3637
.then(() => useCIChrome('e2e'))
3738
.then(() => useCIChrome('src'))
3839
.then(() => argv['ng-version'] ? useNgVersion(argv['ng-version']) : Promise.resolve())

tests/e2e/utils/project.ts

+11
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export function createProject(name: string, ...args: string[]) {
3535
const argv: any = getGlobalVariable('argv');
3636

3737
return Promise.resolve()
38+
.then(() => useDevKitSnapshots())
3839
.then(() => process.chdir(getGlobalVariable('tmp-root')))
3940
.then(() => ng('new', name, '--skip-install', ...args))
4041
.then(() => process.chdir(name))
@@ -75,6 +76,16 @@ export function useDevKit(devkitRoot: string) {
7576
});
7677
}
7778

79+
export function useDevKitSnapshots() {
80+
return updateJsonFile('package.json', json => {
81+
json['devDependencies']['@angular-devkit/build-angular'] =
82+
'github:angular/angular-devkit-build-angular-builds';
83+
// By adding build-ng-packagr preemptively, adding a lib will not update it.
84+
json['devDependencies']['@angular-devkit/build-ng-packagr'] =
85+
'github:angular/angular-devkit-build-ng-packagr-builds';
86+
});
87+
}
88+
7889
export function useBuiltPackages() {
7990
return Promise.resolve()
8091
.then(() => updateJsonFile('package.json', json => {

tools/publish/src/build.ts

+12-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function getDeps(pkg: any): any {
5858

5959

6060
export default function build(packagesToBuild: string[],
61-
opts: { local: boolean, devkit: string },
61+
opts: { local: boolean, devkit: string, 'devkit-snapshots': boolean },
6262
logger: logging.Logger): Promise<void> {
6363
const { packages, tools } = require('../../../lib/packages');
6464

@@ -269,6 +269,17 @@ export default function build(packagesToBuild: string[],
269269
json['devDependencies'][packageName] = devkitPackages[packageName].tar;
270270
}
271271
}
272+
} else if (opts['devkit-snapshots']) {
273+
// Use snapshots for devkit packages.
274+
logger.info('Using snapshots of devkit packages.');
275+
json['dependencies']['@angular-devkit/architect'] =
276+
'github:angular/angular-devkit-architect-builds';
277+
json['dependencies']['@angular-devkit/core'] =
278+
'github:angular/angular-devkit-core-builds';
279+
json['dependencies']['@angular-devkit/schematics'] =
280+
'github:angular/angular-devkit-schematics-builds';
281+
json['dependencies']['@schematics/angular'] = 'github:angular/schematics-angular-builds';
282+
json['dependencies']['@schematics/update'] = 'github:angular/schematics-update-builds';
272283
}
273284

274285
fs.writeFileSync(pkg.distPackageJson, JSON.stringify(json, null, 2));

0 commit comments

Comments
 (0)