Skip to content

Commit 1cc2d65

Browse files
jbedardclydin
authored andcommitted
build: allow no-remote-exec targets to be cached on CI
1 parent 0bafddf commit 1cc2d65

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

.circleci/dynamic_config.yml

-8
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,6 @@ commands:
142142
# cause decryption failures based on the openssl version. https://stackoverflow.com/a/39641378/4317734
143143
openssl aes-256-cbc -d -in .circleci/gcp_token -md md5 -k "${<< parameters.key >>}" -out /home/circleci/.gcp_credentials;
144144
sudo bash -c "echo -e 'build --google_credentials=/home/circleci/.gcp_credentials' >> .bazelrc.user";
145-
# Upload/don't upload local results to cache based on environment
146-
if [[ -n "{$CIRCLE_PULL_REQUEST}" ]]; then
147-
sudo bash -c "echo -e 'build:remote --remote_upload_local_results=false\n' >> .bazelrc.user";
148-
echo "Not uploading local build results to remote cache.";
149-
else
150-
sudo bash -c "echo -e 'build:remote --remote_upload_local_results=true\n' >> .bazelrc.user";
151-
echo "Uploading local build results to remote cache.";
152-
fi
153145
# Enable remote builds
154146
sudo bash -c "echo -e 'build --config=remote' >> .bazelrc.user";
155147
echo "Reading from remote cache for bazel remote jobs.";

packages/angular_devkit/core/BUILD.bazel

-2
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ ts_library(
7070
jasmine_node_test(
7171
name = "core_test_" + toolchain_name,
7272
srcs = [":core_test_lib"],
73-
# TODO: Audit tests to determine if tests can be run in RBE environments
74-
local = True,
7573
toolchain = toolchain,
7674
deps = [
7775
# @node_module: ajv

0 commit comments

Comments
 (0)