Skip to content

Commit 1bf9634

Browse files
alan-agius4hansl
authored andcommitted
fix(@angular/cli): --verbose is an unknown option of serve
Closes #11086
1 parent 72ded97 commit 1bf9634

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

packages/angular_devkit/build_angular/src/dev-server/index.ts

+2
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ export interface DevServerBuilderOptions {
5757
baseHref?: string;
5858
progress?: boolean;
5959
poll?: number;
60+
verbose?: boolean;
6061
}
6162

6263

@@ -407,6 +408,7 @@ export class DevServerBuilder implements Builder<DevServerBuilderOptions> {
407408
...(options.baseHref !== undefined ? { baseHref: options.baseHref } : {}),
408409
...(options.progress !== undefined ? { progress: options.progress } : {}),
409410
...(options.poll !== undefined ? { poll: options.poll } : {}),
411+
...(options.verbose !== undefined ? { verbose: options.verbose } : {}),
410412
};
411413

412414
const browserTargetSpec = { project, target, configuration, overrides };

packages/angular_devkit/build_angular/src/dev-server/schema.json

+5
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@
4040
"default": false,
4141
"alias": "o"
4242
},
43+
"verbose": {
44+
"type": "boolean",
45+
"description": "Adds more details to output logging.",
46+
"default": false
47+
},
4348
"liveReload": {
4449
"type": "boolean",
4550
"description": "Whether to reload the page on change, using live-reload.",

packages/angular_devkit/build_angular/test/dev-server/works_spec_large.ts

+11-1
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import { request, runTargetSpec } from '@angular-devkit/architect/testing';
9+
import { TestLogger, request, runTargetSpec } from '@angular-devkit/architect/testing';
1010
import { from } from 'rxjs';
1111
import { concatMap, take, tap } from 'rxjs/operators';
12+
import { DevServerBuilderOptions } from '../../src';
1213
import { devServerTargetSpec, host } from '../utils';
1314

1415

@@ -24,4 +25,13 @@ describe('Dev Server Builder', () => {
2425
take(1),
2526
).toPromise().then(done, done.fail);
2627
}, 30000);
28+
29+
it('works with verbose', (done) => {
30+
const overrides: Partial<DevServerBuilderOptions> = { verbose: true };
31+
const logger = new TestLogger('verbose-serve');
32+
runTargetSpec(host, devServerTargetSpec, overrides, undefined, logger).pipe(
33+
tap(() => expect(logger.includes('Built at')).toBe(true)),
34+
take(1),
35+
).toPromise().then(done, done.fail);
36+
}, 30000);
2737
});

0 commit comments

Comments
 (0)