fix(@angular-devkit/build-angular): e2e does not respect dev-server host and port settings (#14165)

Fixes #14151

Author: Alan Agius

packages/angular_devkit/build_angular/src/protractor/index.ts

@@ -105,10 +105,21 @@ async function execute(
     const serverOptions = await context.getTargetOptions(target);
 
     const overrides: Record<string, string | number | boolean> = { watch: false };
-    if (options.host !== undefined) { overrides.host = options.host; }
-    if (options.port !== undefined) { overrides.port = options.port; }
-    server = await context.scheduleTarget(target, overrides);
+    if (options.host !== undefined) {
+      overrides.host = options.host;
+    } else if (typeof serverOptions.host === 'string') {
+      options.host = serverOptions.host;
+    } else {
+      options.host = overrides.host = 'localhost';
+    }
 
+    if (options.port !== undefined) {
+      overrides.port = options.port;
+    } else if (typeof serverOptions.port === 'number') {
+      options.port = serverOptions.port;
+    }
+
+    server = await context.scheduleTarget(target, overrides);
     let result;
     try {
       result = await server.result;

packages/angular_devkit/build_angular/src/protractor/schema.json

@@ -41,8 +41,7 @@
     },
     "host": {
       "type": "string",
-      "description": "Host to listen on.",
-      "default": "localhost"
+      "description": "Host to listen on."
     },
     "baseUrl": {
       "type": "string",

tests/legacy-cli/e2e/tests/misc/e2e-host.ts

@@ -0,0 +1,28 @@
+import * as os from 'os';
+import { killAllProcesses, ng } from '../../utils/process';
+import { updateJsonFile } from '../../utils/project';
+
+export default async function () {
+  const interfaces = [].concat.apply([], Object.values(os.networkInterfaces()));
+  let host = '';
+  for (const { family, address, internal } of interfaces) {
+    if (family === 'IPv4' && !internal) {
+      host = address;
+      break;
+    }
+  }
+
+  try {
+    await updateJsonFile('angular.json', workspaceJson => {
+      const appArchitect = workspaceJson.projects['test-project'].architect;
+      appArchitect.serve.options.port = 8888;
+      appArchitect.serve.options.host = host;
+    });
+
+    await ng('e2e');
+
+    await ng('e2e', '--host', host);
+  } finally {
+    await killAllProcesses();
+  }
+}