Skip to content

Commit 084dad6

Browse files
clydindgp1130
authored andcommitted
refactor(@angular-devkit/build-angular): remove nonexistent argument from rxjs path mapping call
The rxjs path mapping function does not have any parameters and has not since version 5.5.0 which is not supported. (cherry picked from commit d918af3)
1 parent b3625e9 commit 084dad6

File tree

1 file changed

+2
-7
lines changed
  • packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs

1 file changed

+2
-7
lines changed

packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import { NamedLazyChunksPlugin } from '../../plugins/named-chunks-plugin';
3636
import { OptimizeCssWebpackPlugin } from '../../plugins/optimize-css-webpack-plugin';
3737
import { ScriptsWebpackPlugin } from '../../plugins/scripts-webpack-plugin';
3838
import { WebpackRollupLoader } from '../../plugins/webpack';
39-
import { findAllNodeModules, findUp } from '../../utilities/find-up';
39+
import { findAllNodeModules } from '../../utilities/find-up';
4040
import { WebpackConfigOptions } from '../build-options';
4141
import { getEsVersionForFileName, getOutputHashFormat, normalizeExtraEntryPoints } from './utils';
4242

@@ -55,11 +55,6 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
5555
vendor: vendorSourceMap,
5656
} = buildOptions.sourceMap;
5757

58-
const nodeModules = findUp('node_modules', projectRoot);
59-
if (!nodeModules) {
60-
throw new Error('Cannot locate node_modules directory.');
61-
}
62-
6358
const extraPlugins: Plugin[] = [];
6459
const extraRules: Rule[] = [];
6560
const entryPoints: { [key: string]: string[] } = {};
@@ -363,7 +358,7 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
363358
? 'rxjs/_esm2015/path-mapping'
364359
: 'rxjs/_esm5/path-mapping';
365360
const rxPaths = require(require.resolve(rxjsPathMappingImport, { paths: [projectRoot] }));
366-
alias = rxPaths(nodeModules);
361+
alias = rxPaths();
367362
} catch {}
368363

369364
const extraMinimizers = [];

0 commit comments

Comments
 (0)