Skip to content

Commit 0089ec1

Browse files
devversionalan-agius4
authored andcommitted
build: use rbe platform with network from shared dev-infra build tooling
This avoids having to manually declare the `platform`. We specifically added support for the network platform due to the CLI needs. The CLI repository should long-term set `--sandbox_default_allow_network=false` in the `bazelrc` so that internet access is only granted targets explicitly. We should discourage reliance on internet as much as possible to help with hermetic tests.
1 parent 652a4af commit 0089ec1

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

.bazelrc

+3-3
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,9 @@ build:remote --jobs=150
120120
# is provided by the shared dev-infra package and targets k8 remote containers.
121121
build:remote --crosstool_top=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain_suite
122122
build:remote --extra_toolchains=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain
123-
build:remote --extra_execution_platforms=//tools:rbe_platform_with_network_access
124-
build:remote --host_platform=//tools:rbe_platform_with_network_access
125-
build:remote --platforms=//tools:rbe_platform_with_network_access
123+
build:remote --extra_execution_platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
124+
build:remote --host_platform=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
125+
build:remote --platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
126126

127127
# Set remote caching settings
128128
build:remote --remote_accept_cached=true

tools/BUILD.bazel

-9
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,4 @@ nodejs_binary(
2828
entry_point = "quicktype_runner.js",
2929
templated_args = ["--bazel_patch_module_resolver"],
3030
)
31-
32-
platform(
33-
name = "rbe_platform_with_network_access",
34-
exec_properties = {
35-
"dockerNetwork": "standard",
36-
},
37-
parents = ["@npm//@angular/build-tooling/bazel/remote-execution:platform"],
38-
)
39-
4031
# @external_end

0 commit comments

Comments
 (0)