Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Commit 69071ee

Browse files
Rémi Becherasdeeg
Rémi Becheras
authored andcommitted
(chore): Refactor event handlers.
Combines update events into one handler. Closes #233
1 parent fa0be56 commit 69071ee

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

src/tinymce.js

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,12 @@ angular.module('ui.tinymce', [])
6969
}
7070
});
7171

72-
// Update model on button click
73-
ed.on('ExecCommand', function() {
74-
ed.save();
75-
updateView(ed);
76-
});
77-
78-
// Update model on change
79-
ed.on('change NodeChange', function() {
72+
// Update model when:
73+
// - a button has been clicked [ExecCommand]
74+
// - the editor content has been modified [change]
75+
// - the node has changed [NodeChange]
76+
// - an object has been resized (table, image) [ObjectResized]
77+
ed.on('ExecCommand change NodeChange ObjectResized', function() {
8078
ed.save();
8179
updateView(ed);
8280
});
@@ -87,12 +85,6 @@ angular.module('ui.tinymce', [])
8785
scope.$digest();
8886
});
8987

90-
// Update model when an object has been resized (table, image)
91-
ed.on('ObjectResized', function() {
92-
ed.save();
93-
updateView(ed);
94-
});
95-
9688
ed.on('remove', function() {
9789
element.remove();
9890
});
@@ -114,7 +106,7 @@ angular.module('ui.tinymce', [])
114106
// re-rendering directive
115107
$timeout(function() {
116108
if (options.baseURL){
117-
tinymce.baseURL = options.baseURL;
109+
tinymce.baseURL = options.baseURL;
118110
}
119111
tinymce.init(options);
120112
toggleDisable(scope.$eval(attrs.ngDisabled));

0 commit comments

Comments
 (0)