Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Commit 17243a4

Browse files
committed
Merge pull request #205 from angular-ui/dev
Merging dev with master branch for release .12
2 parents 9d9e468 + a67e73c commit 17243a4

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

CONTRIBUTING.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,16 @@ We are always looking for the quality contributions and will be happy to accept
3030

3131
* Please open all pull requests against the `dev` branch.
3232
* Please assure that you are submitting quality code, specifically make sure that:
33-
* You have accompanying tests and all the tests are passing.
33+
* You have accompanying tests and all the tests are passing. See testing below.
3434
* Your PR doesn't break the build; check the Travis-CI build status after opening a PR and push corrective commits if anything goes wrong
3535
* You are using 2 space indentation
36-
* Your commits conform to the conventions established [here](https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md)
36+
* Your commits conform to the conventions established [here](https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md)
37+
38+
39+
## Testing
40+
To run tests:
41+
```bash
42+
$ npm install
43+
$ bower install
44+
$ grunt
45+
```

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ In addition, it supports these additional optional options
9898

9999
- `format` Format to get content as, i.e. 'raw' for raw HTML, or 'text' for text only. Defaults to 'html'. Documentation [here](http://www.tinymce.com/wiki.php/api4:method.tinymce.Editor.getContent)
100100
- `trusted` When `true`, all TinyMCE content that is set to `ngModel` will be whitelisted by `$sce`
101+
- `baseURL` This will set [baseURL property on the EditorManager](https://www.tinymce.com/docs/api/class/tinymce.editormanager/)
101102

102103
This option is only supported when present on the `uiTinymceConfig` global injectable - this injectable needs to be an object.
103104

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"devDependencies": {
1111
"grunt": "~0.4.4",
1212
"grunt-karma": "~0.8.2",
13+
"karma": "~0.12.0",
1314
"grunt-contrib-jshint": "~0.10.0",
1415
"grunt-conventional-changelog": "~1.0.0",
1516
"jasmine-core": "~2.3.4",

src/tinymce.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,9 @@ angular.module('ui.tinymce', [])
109109
// element to be present in DOM before instantiating editor when
110110
// re-rendering directive
111111
$timeout(function() {
112+
if (options.baseURL){
113+
tinymce.baseURL = options.baseURL;
114+
}
112115
tinymce.init(options);
113116
toggleDisable(scope.$eval(attrs.ngDisabled));
114117
});

0 commit comments

Comments
 (0)