memory efficiency with angular.noop

michaschwab · michaschwab · commit ec6567f66a6d · 2016-03-11T11:51:45.000-05:00
diff --git a/src/sortable.js b/src/sortable.js
@@ -448,7 +448,7 @@ angular.module('ui.sortable', [])
             $log.info('ui.sortable: ngModel not provided!', element);
           }
 
-          var listener = function() {};
+          var stopDisabledWatcher = angular.noop;
 
           var startIfEnabled = function()
           {
@@ -458,7 +458,7 @@ angular.module('ui.sortable', [])
               element.sortable(opts);
 
               // Stop Watcher
-              listener();
+              stopDisabledWatcher();
 
               return true;
             }
@@ -467,7 +467,7 @@ angular.module('ui.sortable', [])
 
           if(!startIfEnabled())
           {
-            listener = scope.$watch('uiSortable.disabled', startIfEnabled);
+            stopDisabledWatcher = scope.$watch('uiSortable.disabled', startIfEnabled);
           }
         }
       };

Original file line number	Diff line number	Diff line change
`@@ -448,7 +448,7 @@ angular.module('ui.sortable', [])`
`448`	`448`	`$log.info('ui.sortable: ngModel not provided!', element);`
`449`	`449`	`}`
`450`	`450`
`451`		`- var listener = function() {};`
	`451`	`+ var stopDisabledWatcher = angular.noop;`
`452`	`452`
`453`	`453`	`var startIfEnabled = function()`
`454`	`454`	`{`
`@@ -458,7 +458,7 @@ angular.module('ui.sortable', [])`
`458`	`458`	`element.sortable(opts);`
`459`	`459`
`460`	`460`	`// Stop Watcher`
`461`		`- listener();`
	`461`	`+ stopDisabledWatcher();`
`462`	`462`
`463`	`463`	`return true;`
`464`	`464`	`}`
`@@ -467,7 +467,7 @@ angular.module('ui.sortable', [])`
`467`	`467`
`468`	`468`	`if(!startIfEnabled())`
`469`	`469`	`{`
`470`		`- listener = scope.$watch('uiSortable.disabled', startIfEnabled);`
	`470`	`+ stopDisabledWatcher = scope.$watch('uiSortable.disabled', startIfEnabled);`
`471`	`471`	`}`
`472`	`472`	`}`
`473`	`473`	`};`