This repository was archived by the owner on Oct 2, 2019. It is now read-only.
feat(focus): allow to set focus when loaded or listening a scope event #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functionality looks awesome 👍 Can't wait to have it. |
|
I'm dropping the implementation via directives for now, and just adding to uiSelect link fn New plunker demo |
dimirc
added a commit
that referenced
this pull request
Mar 9, 2015
feat(focus): allow to set focus when loaded or listening a scope event
|
v0.11.0 released |
Closed
|
In multi on on-focus event it sets focus on input but not open suggestions. Can You open suggestion (as on |
|
@dimirc working great. Our application has a small issue: We're not using any outline on focus: May be the same issue as @piernik's? Does one need to trigger an activate() to get the curser? Is it doable with your code as written? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could have 2 ways to set focus:
autofocusto automatically get focus when loadedfocus-onto define a scope event name to listen (e.g.focus-on='SomeEventName')Demo plunker
I wanted to have this implementation on directives but to use autofocus/focus-on names could create conflict with other directives since the names will be somehow generic, so I'm just checking for these attributes and append the corresponding directives (with more specific names) if detected on compile fn.
To understand better the changes, will be cleaner to check diff without whitespaces
https://github.com/angular-ui/ui-select/pull/728/files?w=1