From b7475e79d141772bf0b7c24ae68e693ebe4c7a02 Mon Sep 17 00:00:00 2001 From: Dondi Dionisio Date: Wed, 23 Mar 2016 14:16:29 -0700 Subject: [PATCH] fix(select-choices): Possible fix for #1355 ...at the cost of potential unnecessary watches when dropdown is closed. But the premise is that, until the resulting errors are fixed, the preference is to avoid the errors for now. Closes #1355 --- src/uiSelectChoicesDirective.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/uiSelectChoicesDirective.js b/src/uiSelectChoicesDirective.js index 57d4ae0d9..1b4ea9d04 100644 --- a/src/uiSelectChoicesDirective.js +++ b/src/uiSelectChoicesDirective.js @@ -44,8 +44,7 @@ uis.directive('uiSelectChoices', throw uiSelectMinErr('rows', "Expected 1 .ui-select-choices-row but got '{0}'.", choices.length); } - choices.attr('ng-repeat', $select.parserResult.repeatExpression(groupByExp)) - .attr('ng-if', '$select.open'); //Prevent unnecessary watches when dropdown is closed + choices.attr('ng-repeat', $select.parserResult.repeatExpression(groupByExp)); if ($window.document.addEventListener) { //crude way to exclude IE8, specifically, which also cannot capture events choices.attr('ng-mouseenter', '$select.setActiveItem('+$select.parserResult.itemName +')') .attr('ng-click', '$select.select(' + $select.parserResult.itemName + ',$select.skipFocusser,$event)');