$select.selected gets wrong values for uiSelectMultiple

[FarSeeing]

uiSelectMultipleDirective.js#L143

        if(!angular.isArray(ngModel.$viewValue)){
          // Have tolerance for null or undefined values
          if(angular.isUndefined(ngModel.$viewValue) || ngModel.$viewValue === null){
            $select.selected = [];
          } else {
            throw uiSelectMinErr('multiarr', "Expected model value to be array but got '{0}'", ngModel.$viewValue);
          }
        }
        $select.selected = ngModel.$viewValue;

The check for ngModel.$viewValue being null or undefined makes no sense now as $select.selected will still get the original value of ngModel.$viewValue.

[awerlang]

+1

[nesinervink]

+1

This code needs testing, but seems like it solves all the issues with $select.selected being undefined, because on $render $select.selected is assigned model's $viewValue before $watch in uiSelectSingleDirective.js#L42 sets the $viewValue to empty array in case $select.selected was undefined.

nesinervink/ui-select@0c1764a

ngModel.$render = function() {
  // Make sure that model value is array
  if(!angular.isArray(ngModel.$viewValue)){
    // Have tolerance for null or undefined values
    if(angular.isUndefined(ngModel.$viewValue) || ngModel.$viewValue === null){
      $select.selected = [];
    } else {
      throw uiSelectMinErr('multiarr', "Expected model value to be array but got '{0}'", ngModel.$viewValue);
    }
  } else {
    $select.selected = ngModel.$viewValue;
  }

  $selectMultiple.refreshComponent();
  scope.$evalAsync(); //To force $digest
};

[nesinervink]

Problem persists in v0.18.0 and this push still solves it.

[user378230]

This should be resolved by #1709, please update this issue if it does not (when the next version is released).