Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Commit f38afd2

Browse files
committed
Merge pull request #1295 from atomx/href
fix(ng-click): fix broken ng-click This pull request removes the ng-click with prevent default because an empty href in angular does exactly the same. See: https://docs.angularjs.org/api/ng/directive/a Here is an example of the current master version: http://plnkr.co/edit/O2tbRRFOC0IDwHI363cM?p=preview And here is an example with this change: http://plnkr.co/edit/MXW3abVF9l0fzYElYDv1?p=preview
2 parents 497b5ed + 38e239a commit f38afd2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/bootstrap/choices.tpl.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<div ng-show="$select.isGrouped" class="ui-select-choices-group-label dropdown-header" ng-bind="$group.name"></div>
77
<div id="ui-select-choices-row-{{ $select.generatedId }}-{{$index}}" class="ui-select-choices-row"
88
ng-class="{active: $select.isActive(this), disabled: $select.isDisabled(this)}" role="option">
9-
<a ng-click="$event.preventDefault()" class="ui-select-choices-row-inner"></a>
9+
<a href="" class="ui-select-choices-row-inner"></a>
1010
</div>
1111
</li>
1212
</ul>

0 commit comments

Comments
 (0)