fix(choices): avoid to recalculate position when set 'down'

dimirc · dimirc · commit abc4ce929808 · 2015-09-29T23:49:47.000-05:00
diff --git a/src/uiSelectController.js b/src/uiSelectController.js
@@ -169,7 +169,6 @@ uis.controller('uiSelectCtrl',
     }
 
     ctrl.refreshItems = function (data){
-      $scope.calculateDropdownPos();
       data = data || ctrl.parserResult.source($scope);
       var selectedItems = ctrl.selected;
       //TODO should implement for single mode removeSelected
@@ -181,6 +180,9 @@ uis.controller('uiSelectCtrl',
           ctrl.setItemsFn(filteredItems);
         }
       }
+      if (ctrl.dropdownPosition === 'auto' || ctrl.dropdownPosition === 'up'){
+        $scope.calculateDropdownPos();
+      }
     };
 
     // See https://github.com/angular/angular.js/blob/v1.2.15/src/ng/directive/ngRepeat.js#L259

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,6 @@ uis.controller('uiSelectCtrl',`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`ctrl.refreshItems = function (data){`
`172`		`- $scope.calculateDropdownPos();`
`173`	`172`	`data = data \|\| ctrl.parserResult.source($scope);`
`174`	`173`	`var selectedItems = ctrl.selected;`
`175`	`174`	`//TODO should implement for single mode removeSelected`
`@@ -181,6 +180,9 @@ uis.controller('uiSelectCtrl',`
`181`	`180`	`ctrl.setItemsFn(filteredItems);`
`182`	`181`	`}`
`183`	`182`	`}`
	`183`	`+ if (ctrl.dropdownPosition === 'auto' \|\| ctrl.dropdownPosition === 'up'){`
	`184`	`+ $scope.calculateDropdownPos();`
	`185`	`+ }`
`184`	`186`	`};`
`185`	`187`
`186`	`188`	`// See https://github.com/angular/angular.js/blob/v1.2.15/src/ng/directive/ngRepeat.js#L259`