Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Commit 6b49994

Browse files
committed
Merge pull request #1405 from christopher-ramirez/master
fix(iuSelectMultiple): add check prior to mutating immutable property The `_findApproxDupe` was throwing an error when the `isTag` property was being added to a primitive value. These types of values are received when $select.selected holds an array of privitive values (using key binding).
2 parents fa47fba + e57d131 commit 6b49994

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/uiSelectMultipleDirective.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,9 +383,11 @@ uis.directive('uiSelectMultiple', ['uiSelectMinErr','$timeout', function(uiSelec
383383
// handle the object tagging implementation
384384
} else {
385385
var mockObj = tempArr[i];
386-
mockObj.isTag = true;
386+
if (angular.isObject(mockObj)) {
387+
mockObj.isTag = true;
388+
}
387389
if ( angular.equals(mockObj, needle) ) {
388-
dupeIndex = i;
390+
dupeIndex = i;
389391
}
390392
}
391393
}

0 commit comments

Comments
 (0)