Add test

Author: abudel

src/select.js

@@ -1288,7 +1288,7 @@
           $select.disableChoiceExpression = attrs.uiDisableChoice;
           $select.onHighlightCallback = attrs.onHighlight;
 
-          $select.refreshOnActive = attrs.refreshOnActive;
+          $select.refreshOnActive = scope.$eval(attrs.refreshOnActive);
 
           if(groupByExp) {
             var groups = element.querySelectorAll('.ui-select-choices-group');
@@ -1315,13 +1315,13 @@
           scope.$watch('$select.search', function(newValue) {
             if(newValue && !$select.open && $select.multiple) $select.activate(false, true);
             $select.activeIndex = $select.tagging.isActivated ? -1 : 0;
-            if(angular.isUndefined($select.refreshOnActive) || ($select.refreshOnActive && $select.refreshIsActive)) {
+            if(!$select.refreshOnActive || ($select.refreshOnActive && $select.refreshIsActive)) {
               $select.refresh(attrs.refresh);
             }
           });
 
-          scope.$watch('$select.refreshIsActive', function(value){
-            if(angular.isUndefined(value)){
+          scope.$watch('$select.refreshIsActive', function(newValue, oldValue){
+            if(angular.isUndefined(oldValue) && newValue){
               $select.refresh(attrs.refresh);
             }
           });

test/select.spec.js

@@ -191,7 +191,7 @@ describe('ui-select tests', function() {
 
     expect(getMatchLabel(el)).toEqual('Adam');
   });
-  
+
   it('should correctly render initial state with track by feature', function() {
     var el = compileTemplate(
       '<ui-select ng-model="selection.selected"> \
@@ -1791,4 +1791,33 @@ describe('ui-select tests', function() {
       }
     });
   });
+
+  describe('with refresh on active', function(){
+    it('should not refresh untill is activate', function(){
+
+      var el = compileTemplate(
+        '<ui-select ng-model="selection.selected"> \
+          <ui-select-match> \
+          </ui-select-match> \
+          <ui-select-choices repeat="person in people | filter: $select.search" \
+            refresh="fetchFromServer($select.search)" refresh-on-active="true" refresh-delay="0"> \
+            <div ng-bind-html="person.name | highlight: $select.search"></div> \
+            <div ng-if="person.name==\'Wladimir\'"> \
+              <span class="only-once">I should appear only once</span>\
+            </div> \
+          </ui-select-choices> \
+        </ui-select>'
+      );
+
+      scope.fetchFromServer = function(){};
+      spyOn(scope, 'fetchFromServer');
+      $timeout.flush();
+      expect(scope.fetchFromServer.calls.any()).toEqual(false);
+
+      el.scope().$select.activate();
+      $timeout.flush();
+      expect(scope.fetchFromServer.calls.any()).toEqual(true);
+    });
+
+  });
 });