Fix: refresh function, every new search removes items selected earlier

Author: dimirc

src/select.js

@@ -568,31 +568,36 @@
           if (data){
             if ($select.multiple){
               var resultMultiple = [];
-              for (var k = inputValue.length - 1; k >= 0; k--) {
-                for (var j = data.length - 1; j >= 0; j--) {
-                  locals = {};
-                  locals[$select.parserResult.itemName] = data[j];
+              var checkFnMultiple = function(list, value){
+                if (!list || !list.length) return;
+                for (var p = list.length - 1; p >= 0; p--) {
+                  locals[$select.parserResult.itemName] = list[p];
                   result = $select.parserResult.modelMapper(scope, locals);
-                  if (result == inputValue[k]){
-                    resultMultiple.unshift(data[j]);
-                    break;
+                  if (result == value){
+                    resultMultiple.unshift(list[p]);
+                    return true;
                   }
                 }
+                return false;
+              };
+              for (var k = inputValue.length - 1; k >= 0; k--) {
+                if (!checkFnMultiple($select.selected, inputValue[k])){
+                  checkFnMultiple(data, inputValue[k]);
+                }
               }
               return resultMultiple;
             }else{
-              var checkFn = function(d){
-                locals = {};
+              var checkFnSingle = function(d){
                 locals[$select.parserResult.itemName] = d;
                 result = $select.parserResult.modelMapper(scope, locals);
                 return result == inputValue;
               };
               //If possible pass same object stored in $select.selected
-              if ($select.selected && checkFn($select.selected)) {
+              if ($select.selected && checkFnSingle($select.selected)) {
                 return $select.selected;
               }
               for (var i = data.length - 1; i >= 0; i--) {
-                if (checkFn(data[i])) return data[i];
+                if (checkFnSingle(data[i])) return data[i];
               }
             }
           }

test/select.spec.js

@@ -1036,6 +1036,47 @@ describe('ui-select tests', function() {
 
     });
 
+    it('should format view value correctly when using single property binding and refresh funcion', function () {
+      
+      scope.selection.selectedMultiple = ['[email protected]', '[email protected]'];
+
+      var el = compileTemplate(
+          '<ui-select multiple ng-model="selection.selectedMultiple" theme="bootstrap" style="width: 800px;"> \
+              <ui-select-match placeholder="Pick one...">{{$item.name}} &lt;{{$item.email}}&gt;</ui-select-match> \
+              <ui-select-choices repeat="person.email as person in people | filter: $select.search" \
+                refresh="fetchFromServer($select.search)" refresh-delay="0"> \
+                <div ng-bind-html="person.name | highlight: $select.search"></div> \
+                <div ng-bind-html="person.email | highlight: $select.search"></div> \
+              </ui-select-choices> \
+          </ui-select>'
+      );
+
+      var searchInput = el.find('.ui-select-search');
+
+      scope.fetchFromServer = function(searching){
+
+        if (searching == 'n')
+          return scope.people 
+        
+        if (searching == 'o'){
+          scope.people = []; //To simulate cases were previously selected item isnt in the list anymore
+        }
+
+      };
+
+      setSearchText(el, 'n')
+      clickItem(el, 'Nicole');
+
+      expect(el.find('.ui-select-match-item [uis-transclude-append]:not(.ng-hide)').text())
+        .toBe("Wladimir <[email protected]>Samantha <[email protected]>Nicole <[email protected]>");
+
+      setSearchText(el, 'o')
+
+      expect(el.find('.ui-select-match-item [uis-transclude-append]:not(.ng-hide)').text())
+        .toBe("Wladimir <[email protected]>Samantha <[email protected]>Nicole <[email protected]>");
+
+    });
+
   });