Skip to content

Internet Explorer (IE) Compatibility #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wrengland opened this issue Nov 17, 2016 · 2 comments
Closed

Internet Explorer (IE) Compatibility #126

wrengland opened this issue Nov 17, 2016 · 2 comments

Comments

@wrengland
Copy link

Implementation of Cache() in angular-ui-scroll#1.5.1 (installed via bower) is not compatible with Internet Explorer due to the use of Array.prototype.find(). See snippet below.

    function Cache() {
      var cache = Object.create(Array.prototype);

      angular.extend(cache, {
        add: function add(item) {
          var existedItem = cache.find(function (i) {

Issue appears to not be present in the current master.

@dhilt
Copy link
Member

dhilt commented Nov 18, 2016

@wrengland thanks! will fix it soon
This issue reminds me of #112 and of releasing ui-scroll 1.5.2 version...

@dhilt
Copy link
Member

dhilt commented Nov 18, 2016

@wrengland v1.5.2 is released, it includes the fix for this issue.

@dhilt dhilt closed this as completed Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants