Skip to content

adaptor binds to expression in wrong scope #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
l3utterfly opened this issue Jul 23, 2016 · 5 comments
Closed

adaptor binds to expression in wrong scope #113

l3utterfly opened this issue Jul 23, 2016 · 5 comments

Comments

@l3utterfly
Copy link

When using ui-scroll within a directive with a controller with the ControllerAs syntax, the adaptor seems to be binding to the wrong scope.

E.g. with a controller as cTest, setting adaptor="cTest.adapter". Using ng-inspector, I see that the "adapter" variable is in the $rootScope.cTest.adapter

I don't have an isolated test case just yet, but this happened in the latest version (I was using ui-scroll before with the same syntax it was working properly).

@mfeingold
Copy link
Contributor

mfeingold commented Jul 23, 2016

hmm... There was no (intentional) changes to the way as controller syntax works since its introduction

@dhilt
Copy link
Member

dhilt commented Oct 13, 2016

Possibly this one relates to #119 issue.

@dhilt
Copy link
Member

dhilt commented Oct 21, 2016

...and also to #121 issue.

@dhilt
Copy link
Member

dhilt commented Oct 30, 2016

@l3utterfly could you try the latest source code (https://github.com/angular-ui/ui-scroll/blob/master/src/ui-scroll.js)? there are some modifications around adapter assignment... If you still facing the issue please give us a repro (on plunker, jsfiddle etc) or put your full template code in a comment.

@dhilt
Copy link
Member

dhilt commented Nov 18, 2016

Since the 1.5.2 ui-scroll has been released, the assignments/binding issues should dissapear.

@dhilt dhilt closed this as completed Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants