-
Notifications
You must be signed in to change notification settings - Fork 107
adaptor binds to expression in wrong scope #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hmm... There was no (intentional) changes to the way as controller syntax works since its introduction |
Possibly this one relates to #119 issue. |
...and also to #121 issue. |
@l3utterfly could you try the latest source code (https://github.com/angular-ui/ui-scroll/blob/master/src/ui-scroll.js)? there are some modifications around adapter assignment... If you still facing the issue please give us a repro (on plunker, jsfiddle etc) or put your full template code in a comment. |
Since the 1.5.2 ui-scroll has been released, the assignments/binding issues should dissapear. |
When using ui-scroll within a directive with a controller with the ControllerAs syntax, the adaptor seems to be binding to the wrong scope.
E.g. with a controller as cTest, setting adaptor="cTest.adapter". Using ng-inspector, I see that the "adapter" variable is in the $rootScope.cTest.adapter
I don't have an isolated test case just yet, but this happened in the latest version (I was using ui-scroll before with the same syntax it was working properly).
The text was updated successfully, but these errors were encountered: