@@ -99,7 +99,7 @@ angular.module('ui.scroll', [])
99
99
buffer . first = origin ;
100
100
buffer . next = origin ;
101
101
buffer . minIndex = Number . MAX_VALUE ;
102
- return buffer . maxIndex = Number . MIN_VALUE ;
102
+ buffer . maxIndex = Number . MIN_VALUE ;
103
103
}
104
104
105
105
angular . extend ( buffer , {
@@ -566,8 +566,6 @@ angular.module('ui.scroll', [])
566
566
viewport . bind ( 'scroll' , resizeAndScrollHandler ) ;
567
567
viewport . bind ( 'mousewheel' , wheelHandler ) ;
568
568
569
- $scope . $watch ( datasource . revision , ( ) => reload ( ) ) ;
570
-
571
569
$scope . $on ( '$destroy' , ( ) => {
572
570
// clear the buffer. It is necessary to remove the elements and $destroy the scopes
573
571
buffer . clear ( ) ;
@@ -576,6 +574,25 @@ angular.module('ui.scroll', [])
576
574
viewport . unbind ( 'mousewheel' , wheelHandler ) ;
577
575
} ) ;
578
576
577
+ // update events (deprecated since v1.1.0, unsupported since 1.2.0)
578
+ ( ( ) => {
579
+ const eventListener = datasource . scope ? datasource . scope . $new ( ) : $scope . $new ( ) ;
580
+
581
+ eventListener . $on ( 'insert.item' , ( ) => unsupportedMethod ( 'insert' ) ) ;
582
+
583
+ eventListener . $on ( 'update.items' , ( ) => unsupportedMethod ( 'update' ) ) ;
584
+
585
+ eventListener . $on ( 'delete.items' , ( ) => unsupportedMethod ( 'delete' ) ) ;
586
+
587
+ function unsupportedMethod ( token ) {
588
+ throw new Error ( token + ' event is no longer supported - use applyUpdates instead' ) ;
589
+ }
590
+ } ) ( ) ;
591
+
592
+ reload ( ) ;
593
+
594
+ /* Functions definitions */
595
+
579
596
function dismissPendingRequests ( ) {
580
597
ridActual ++ ;
581
598
pending = [ ] ;
@@ -807,21 +824,6 @@ angular.module('ui.scroll', [])
807
824
event . preventDefault ( ) ;
808
825
}
809
826
}
810
-
811
- // update events (deprecated since v1.1.0, unsupported since 1.2.0)
812
- ( ( ) => {
813
- const eventListener = datasource . scope ? datasource . scope . $new ( ) : $scope . $new ( ) ;
814
-
815
- eventListener . $on ( 'insert.item' , ( ) => unsupportedMethod ( 'insert' ) ) ;
816
-
817
- eventListener . $on ( 'update.items' , ( ) => unsupportedMethod ( 'update' ) ) ;
818
-
819
- eventListener . $on ( 'delete.items' , ( ) => unsupportedMethod ( 'delete' ) ) ;
820
-
821
- function unsupportedMethod ( token ) {
822
- throw new Error ( token + ' event is no longer supported - use applyUpdates instead' ) ;
823
- }
824
- } ) ( ) ;
825
827
} ;
826
828
}
827
829
}
0 commit comments