Skip to content

ngAnimate - Is ui-view animation with angular 1.2.10 and ui-router 0.2.8 broken? #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbshopadmin opened this issue Jan 27, 2014 · 14 comments

Comments

@bbshopadmin
Copy link

My ui-view CSS animations looking chaotic after switching from angulars ngRoute to ui-router. My animation classes should be working the same with both, right?

@timkindberg
Copy link
Contributor

Can you please make a plunkr that reproduces the issue?

@bbshopadmin
Copy link
Author

I'll try to do a plunkr, but i'm a noob, so it will take time.

Basically the only change i did in my project (not the plunkr below) was:

// replaced this (works fine)
<div ng-class="transitionClass" ng-view></div>
// with this
<div ng-class="transitionClass" ui-view></div>

@bbshopadmin
Copy link
Author

@timkindberg Have a look here: http://plnkr.co/edit/H3v6sWW9DDQ1qXMeoaXM?p=preview (Angular 1.2.8 with ui-router 0.2.8)

I used your example as base and altered style.css slightly (animation classes).

@ronaldsuwandi
Copy link

Have the same problem too, ui-view not animating with angular 1.2.10 and ui-router 0.2.7

@dlukez
Copy link
Contributor

dlukez commented Jan 29, 2014

This topic has been brought up numerous times, see #786

@timkindberg
Copy link
Contributor

@bbshopadmin looks good when the preview window is wider than the header. I'm not sure what to say, because I don't necessarily know if ui-view is meant to work 1-to-1 the same as ng-view.

@ronaldsuwandi
Copy link

@timkindberg ah it works on 0.2.8. Not working on 0.2.7 though

@timkindberg
Copy link
Contributor

We can only support the most recent version, so I'll consider this fixed.

@bbshopadmin
Copy link
Author

@timkindberg Are you sure? My plunkr does not work on Firefox/Chrome. I see the navbar moving.

@bbshopadmin
Copy link
Author

@dlukez Thanks, but in the plunkr no ng-class is in use.

@bbshopadmin
Copy link
Author

How do i reopen this?

@bbshopadmin
Copy link
Author

Sorry for bugging you, but can someone look into my plunkr (my third post above)? It's clearly not working right here.
I forked the wiki example and only changed the animation classes slightly. It does not use ng-class.

@ronaldsuwandi
Copy link

Just noticed that the animation works but it doesn't work with ng-class (#786, #320)

@timkindberg timkindberg reopened this Jan 30, 2014
@timkindberg
Copy link
Contributor

@bbshopadmin so the plunkr does look odd, but if you pop out the plunkr preview window so its full screen then it looks great. Perhaps this is just bad css. You cannot necessarily assume what looked great on ng-view is going to work for ui-view as well. Please take some time to work with the css and see if you can get it to work. Start over with something simple like a fade. If it still doesn't work, then reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants