-
Notifications
You must be signed in to change notification settings - Fork 3k
ngAnimate - Is ui-view animation with angular 1.2.10 and ui-router 0.2.8 broken? #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you please make a plunkr that reproduces the issue? |
I'll try to do a plunkr, but i'm a noob, so it will take time. Basically the only change i did in my project (not the plunkr below) was: // replaced this (works fine)
<div ng-class="transitionClass" ng-view></div>
// with this
<div ng-class="transitionClass" ui-view></div> |
@timkindberg Have a look here: http://plnkr.co/edit/H3v6sWW9DDQ1qXMeoaXM?p=preview (Angular 1.2.8 with ui-router 0.2.8) I used your example as base and altered style.css slightly (animation classes). |
Have the same problem too, ui-view not animating with angular 1.2.10 and ui-router 0.2.7 |
This topic has been brought up numerous times, see #786 |
@bbshopadmin looks good when the preview window is wider than the header. I'm not sure what to say, because I don't necessarily know if ui-view is meant to work 1-to-1 the same as ng-view. |
@timkindberg ah it works on 0.2.8. Not working on 0.2.7 though |
We can only support the most recent version, so I'll consider this fixed. |
@timkindberg Are you sure? My plunkr does not work on Firefox/Chrome. I see the navbar moving. |
@dlukez Thanks, but in the plunkr no ng-class is in use. |
How do i reopen this? |
Sorry for bugging you, but can someone look into my plunkr (my third post above)? It's clearly not working right here. |
@bbshopadmin so the plunkr does look odd, but if you pop out the plunkr preview window so its full screen then it looks great. Perhaps this is just bad css. You cannot necessarily assume what looked great on ng-view is going to work for ui-view as well. Please take some time to work with the css and see if you can get it to work. Start over with something simple like a fade. If it still doesn't work, then reopen. |
My ui-view CSS animations looking chaotic after switching from angulars ngRoute to ui-router. My animation classes should be working the same with both, right?
The text was updated successfully, but these errors were encountered: