Skip to content

Page jumps to top on state change #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thebigredgeek opened this issue Dec 18, 2013 · 9 comments
Closed

Page jumps to top on state change #697

thebigredgeek opened this issue Dec 18, 2013 · 9 comments

Comments

@thebigredgeek
Copy link

For some reason, when I change a child state, it appears as though the entire browser re-renders, causing it to jump the scroll viewpane to the very top which is very disturbing. Is there a way to bypass this?

@dlukez
Copy link
Contributor

dlukez commented Dec 18, 2013

Not currently, I think it is being triggered by $anchorScroll - https://github.com/angular-ui/ui-router/blob/master/src/viewDirective.js#L126

I imagine an opt out solution might be worthwhile

@dlukez
Copy link
Contributor

dlukez commented Dec 18, 2013

@timkindberg
Copy link
Contributor

We've wanted that for quite a while, its just always low priority. Feel free to make a PR!

@thebigredgeek
Copy link
Author

I think I might, actually. This is a "must-have" for my organization.

@thebigredgeek
Copy link
Author

Does anyone else wanna help out with a PR regarding this? I think what we really want here is to only reload the state views that have actually changed, while leaving everything else alone. It shouldn't be difficult to parse that out of absolute state strings, or child string notation.

@thebigredgeek
Copy link
Author

#700

@dlukez
Copy link
Contributor

dlukez commented Dec 25, 2013

@dlukez
Copy link
Contributor

dlukez commented Jan 8, 2014

This can be closed as a PR has been implemented for this functionality

@nateabele
Copy link
Contributor

Fixed in #715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants