RFC: Remove click binding from uiSref directive

[roryf]

Since the uiSref directive sets the href attribute, I can't see the reasoning behind also binding to the click event and changing state. The event handler seems to further do a bunch of checks to prevent ctrl-click etc. and ensure any ng-click directives are run first.

My use-case for this is I have various links with target="_self" to prevent client-side routing. Previously these had href attributes, but I'm now moving to ui-sref and the target attribute is ignored.

Is there a good reason for binding to click event rather than letting the browser/angular manage the state transition?

[nateabele]

Not all states have URLs, and some states don't map 1:1 with the URLs that represent them.

[roryf]

Thanks, got it now.

Would it be a valid feature to check the target attribute then?

[nateabele]

Definitely.