State: onEnter callback executed before template added to DOM

[iandev]

A states onEnter callback is executed before the template is added to the DOM. In the UI router docs, one of the examples shows a modal dialog being triggered in the state onEnter callback. This is fine, but in the example, the modal doesn't rely on the template being in the DOM already. So, according to the docs, the onEnter/onExit is a good place to open/close a modal dialog, but the states template should be in the DOM by the time the onEnter callback is fired.

[nateabele]

So, according to the docs, the onEnter/onExit is a good place to open/close a modal dialog, but the states template should be in the DOM by the time the onEnter callback is fired.

I don't understand. Is there a question in here?

[iandev]

No, I am saying that onEnter should be fired after the template is added to the DOM. To me, the state has not fully entered until the template is in the DOM. If you don't agree that's fine.

[timkindberg]

I could see it from that pov.

[nateabele]

Well, even if I agreed (which I mostly don't, but we can see about adding another callback if there's a genuine use case), what would you do? Keep in mind, you're still not allowed to touch scopes or the DOM from onEnter either way.

[eddiemonge]

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb