State transitions escape slashes for path-like parameters

[ghost]

For cases such as $stateProvider.state('resource', {url: '/resource/{path:.*}'}), $state.go('resource', {path: 'a/b'}) attempts to go to /resource/a%2Fb.

http://plnkr.co/edit/OoMqgB

[nateabele]

Yup, that's how that works.

[timkindberg]

Hmmm I think it is a valid bug actually: https://github.com/angular-ui/ui-router/blob/master/src/urlMatcherFactory.js#L33-L35

[ghost]

Definitely a bug, at least for *path shorthand. Not sure what's expected behavior for custom regex params.

Perhaps a convention can be introduced for "raw" params? Something along the lines of

{
  url: '/document/{&relativePath:.*}'
}

This patch seems to work for the above suggestion: https://gist.github.com/ntijanic/7116905/revisions

[nateabele]

@timkindberg There are no tests to suggest that catch-all parameters are supposed to work in reverse (and the lack of explicitness that would entail would be a security vulnerability anyway).

@ntijanic Work has already been started to allow typed parameters, which means escaping/unescaping would be user-controllable, which would allow for the above, and be a better system than additional code & complexity added to enable one special case.

[timkindberg]

Ok I see. Makes sense.

[nateabele]

Closing in favor of #454.