UI-router issue with IE8

[baad]

UI-router does not work with IE 8 when I have a button markup like the one below

<input type="submit" class="btn btn-primary" value="Next" data-ui-sref="Users.Create.StepX" />

When I click on the button nothing happens. It works in chrome ,IE9 and IE10 but not in IE8.

It seems the issue is with e.which in below code in angular-ui-router.js.

IE8 doesnot provide any value to e.which and it defaults to 0 and is causing issue.

 element.bind("click", function(e) {
        if ((e.which == 1) && !e.ctrlKey && !e.metaKey && !e.shiftKey) {
          $state.go(ref.state, params, { relative: base });
          scope.$apply();
          e.preventDefault();
        }
      });

[wesleycho]

This is not quite fixed - on IE8, with var button = e.which || e.button, it turns out that button == 0 is true for button elements.

[plopinou]

I have the same problem on IE8, so I just removed the test on (e.which == 1) to have it working correctly for the time being.
A better correction would be to feature detect IE8 with something like :
if ((e.which == 1 || !angular.element("<div> </div>")[0].firstChild) && ...) (from jquery source code)
or simply remove the test with e.which which may not be really that usefull tbh.

I'm in favor of not always adding code for old IE versions, but I still often need to do IE8 compatible websites for customers that are still on XP, so I do require this kind of support for a little longer :)

[scottywakefield]

I agree with plopinou - the less fortunate of us still have to support IE7 and IE8.

[Voles]

This is fixed by #617.

[scottywakefield]

@Voles - much appreciated.

[quantuminformation]

XP will likely be around for longer with big corps paying for patches.

[Voles]

Microsoft will end support for Windows XP on April 8th.
Let's hope those big corps then finally move on!