RC.1 Url Generation Performance Concerns

[calebeno]

This is a:

• Bug Report
• Feature Request
• General Query

My current version of UI-Router is: 1.0.0-beta.3
I am comparing this with version: 1.0.0-rc.1
My version of Angular is: 1.5.8

Bug Report

I am working on a large web application and we have been investigating some performance concerns in the client-side. Among other things, we have some concerns regarding the performance of ui-router, especially when it comes to link generation. We have parts of our application where we are generating 1000+ links in a list. These links (going to the same route) can have between 50-100 potential parameters. Generating this list has caused wait times between 10-20 seconds before successful rendering after stripping the application down to only loading the links without any of the additional content.

I have been doing a comparison between our current version (beta.3) and the newest version (rc.1) to see if the most recent version would have better performance. Unfortunately, rc.1 added to the load time instead of subtracting. I built a jsFiddle example and forked it so each used a different version of ui-router. Here are links to the jsFiddle examples and images taken from Chrome's timeline tools to compare:

Beta.3
http://jsfiddle.net/r1mm0fja/55/

RC.1
http://jsfiddle.net/r1mm0fja/56/

UI Router has been a great utility and we are glad to continue using it. However, I have some concern regarding this performance issue. We are able to create a workaround at this time by manually forming the link using string templating. Will there be an effort to address performance concerns like these before the final release of 1.0?

[samithaf]

@christopherthielen wonder #3370 is related to this defect as well?

[29er]

Yes it looks to be referring to same issue as #3370
We have temporarily removed all StateService.href calls and used other approaches for now.

[christopherthielen]

I've done some optimizing. Is this level of perf acceptable for your app @calebeno ?

http://plnkr.co/edit/wPox4BWUVRGEtglO6zAH?p=preview

[calebeno]

@christopherthielen That is a remarkable improvement! Thank you! When do you think rc.2 will be available?

[christopherthielen]

I've stopped telling people when I think a release will happen because I'm always horribly wrong :)

[calebeno]

That's fair : )

[samithaf]

@christopherthielen I modified your plunker to create 1000 states. With RC1 it takes 11652ms to bootstrap the application. But with your new changes it only takes 255ms. That is impressive 👍

[christopherthielen]

@samithaf that's actually due to a different optimization: #3274 (comment)