Skip to content

Request version bump of NodeJS in Travis #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skoblenick opened this issue Jan 26, 2017 · 0 comments
Closed

Request version bump of NodeJS in Travis #3295

skoblenick opened this issue Jan 26, 2017 · 0 comments
Milestone

Comments

@skoblenick
Copy link

You probably have noticed this yourself; it isn't documented anywhere, but creating a package from master requires Node 6.9.2 yet your travis build defines NodeJS 4.5.

Attempting to run npm run package within Travis CI results in the following failure.

The command "./node_modules/.bin/rollup -c --environment ROUTER" exited with 1.
0.20s$ rollup -c --environment ROUTER,MINIFY
'default' is imported from external module 'rollup-plugin-visualizer' but never used
Unexpected token {
SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Module._extensions..js (module.js:416:10)
    at Object.require.extensions..js (/home/travis/build/username/ui-router/node_modules/rollup/bin/rollup:764:6)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/travis/build/username/ui-router/rollup.config.js:6:46)
    at Module._compile (module.js:409:26)
Type rollup --help for help, or visit https://github.com/rollup/rollup/wiki
The command "rollup -c --environment ROUTER,MINIFY" exited with 1.

The issue is related to the rollup-plugin-visualizer. The plugin is written in ES6 and uses unsupported features in 4.5 such as object deconstruction; specifically Line 17 of plugin.js. Version bumping NodeJS in your .travis.yml will resolve the ability to run npm run package within your build.

Doing so with a few additions to your .travis.yml and Travis build you could auto-release based on version tags; see my fork. If you're interested I'll put in a PR.

@christopherthielen christopherthielen added this to the 1.0.0-rc.2 milestone Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants