Skip to content

Trying to upgrade to 2.0.0-rc.6 #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kolkov opened this issue Sep 1, 2016 · 4 comments
Closed

Trying to upgrade to 2.0.0-rc.6 #2958

kolkov opened this issue Sep 1, 2016 · 4 comments

Comments

@kolkov
Copy link

kolkov commented Sep 1, 2016

D:\!Projects\TypeScript\ui-router\quickstart-ng2>npm update
[email protected] D:\!Projects\TypeScript\ui-router\quickstart-ng2
+-- @angular/[email protected]
+-- @angular/[email protected]
+-- @angular/[email protected]
`-- [email protected]

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: [email protected]
npm WARN [email protected] No repository field.

D:\!Projects\TypeScript\ui-router\quickstart-ng2>npm start

> [email protected] start D:\!Projects\TypeScript\ui-router\quickstart-ng2
> npm run tsc && npm run watch


> [email protected] tsc D:\!Projects\TypeScript\ui-router\quickstart-ng2
> tsc

node_modules/ui-router-ng2/ng2/interface.d.ts(226,17): error TS2314: Generic type 'Type<T>' requires 1 type argument(s).

npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "tsc"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] tsc: `tsc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] tsc script 'tsc'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ui-router-ng2-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ui-router-ng2-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ui-router-ng2-quickstart
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     D:\!Projects\TypeScript\ui-router\quickstart-ng2\npm-debug.log

npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "start"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] start: `npm run tsc && npm run watch`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script 'npm run tsc && npm run watch'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ui-router-ng2-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run tsc && npm run watch
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ui-router-ng2-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ui-router-ng2-quickstart
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     D:\!Projects\TypeScript\ui-router\quickstart-ng2\npm-debug.log

{
  "name": "ui-router-ng2-quickstart",
  "version": "1.0.3",
  "scripts": {
    "start": "npm run tsc && npm run watch",
    "tsc": "tsc",
    "tsc:w": "tsc -w",
    "lite": "lite-server",
    "watch": "npm run tsc:w & npm run lite",
    "typings": "typings",
    "postinstall": "typings install"
  },
  "license": "MIT",
  "dependencies": {
    "es6-shim": "^0.35.0",
    "ui-router-ng2": ">=1.0.0-beta.1",
    "@angular/common": "2.0.0-rc.6",
    "@angular/compiler": "2.0.0-rc.6",
    "@angular/core": "2.0.0-rc.6",
    "@angular/http": "2.0.0-rc.6",
    "@angular/platform-browser": "2.0.0-rc.6",
    "@angular/platform-browser-dynamic": "2.0.0-rc.6",
    "systemjs": "0.19.27",
    "core-js": "^2.4.0",
    "reflect-metadata": "^0.1.3",
    "rxjs": "5.0.0-beta.11",
    "zone.js": "^0.6.17"
  },
  "devDependencies": {
    "lite-server": "^2.1.0",
    "shx": "^0.1.4",
    "typescript": "^1.8.9",
    "typings": "^1.3.2"
  }
}
@kolkov
Copy link
Author

kolkov commented Sep 2, 2016

I builded ui-router for 2.0.0-rc6 with some little changes in three files:
component?: Type; ==> component?: Type<any>;
UrlChangeListener==> LocationChangeListener
Passed all tests and it working as expected in our First UI-Router Angular 2 App ))
Is this correct changes?

@christopherthielen
Copy link
Contributor

Yep! I have also made those changes but haven't pushed to master yet

@kolkov
Copy link
Author

kolkov commented Sep 2, 2016

Thanks, Chris! )

@kolkov
Copy link
Author

kolkov commented Sep 2, 2016

@christopherthielen have you already noticed that PEER-DEPENDENCY UPDATES:
compiler-cli: [email protected]
do we need this too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants