Skip to content

ui-router 1.0.0 external links #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelwarren1106 opened this issue Jan 22, 2016 · 7 comments
Closed

ui-router 1.0.0 external links #2477

michaelwarren1106 opened this issue Jan 22, 2016 · 7 comments

Comments

@michaelwarren1106
Copy link

Hey all,

First off, thanks for the GREAT product! We are currently using this for our angularJS apps across a very large organization, and its great.

The question I have is about a feature that was listed as an enhancement for 0.2.16 and whether or not it made it into 1.0.0

#395

We currently have a library of angularJS components (directives + scss style) that we install in our apps as much as possible. We templatize these directives with config/content JSON objects so that our consuming applications can just configure them, instead of having to write them from scratch, so we have a situation like this:

<header our-header-directive="configObj"></header>


<!--   which turns into -->

<header>

    <nav>
        <ul>
            <li ng-repeat="item in navItems>
                 <a href="{{ item.url }}">{{ item.name }}</a>
                 <!-- in our example item.url could be 'http://www.google.com' or a state ref/internal relative url-->
            </li>
        </ul>
    </nav>

</header>

in 0.2.15, dynamic ui-srefs INSIDE of custom directives didnt work, so we have to use href instead of ui-sref. We'd like to be able to use ui-sref if possible. I dont see any documentation about this feature being added in 1.0.0. Can you please verify?

Thanks!

@nateabele
Copy link
Contributor

Hasn't been merged in yet.

@michaelwarren1106
Copy link
Author

thanks for the fast response. Any estimate for what milestone it might be? is development on the 0.2.x branch going to keep going in parallel to 1.0.0, or do you guys plan a cutover?

@nateabele
Copy link
Contributor

Not sure yet. 0.2.x will still have at least one more release.

@michaelwarren1106
Copy link
Author

ok thanks for the info! Is there at least a working approach for dynamic links in directives? if so, maybe I could look at a PR? I haven't explored much of the project, but this feature would be awesome for us, so if i could help it along in anyway, i'm game.

@christopherthielen
Copy link
Contributor

Merging in the ui-state etc directives should be pretty easy if somebody wants to submit a PR. I'm juggling about a hundred other things and this took a back seat

@christopherthielen
Copy link
Contributor

#2223

This is the commit that needs merging in 3831af1

@christopherthielen
Copy link
Contributor

Merged ui-state directive
a428b2f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants