Skip to content

JSON file has incorrect extension #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimthedev opened this issue Feb 25, 2015 · 1 comment
Closed

JSON file has incorrect extension #1778

jimthedev opened this issue Feb 25, 2015 · 1 comment

Comments

@jimthedev
Copy link
Contributor

Hello hello,

Easily resolved issue here. Bottom line, there is a JSON file in the ui-router repo that has a .js extension even though it isn't javascript. For parsers that assume .js Javascript, this is a problem. The specific file is:

ui-router/config/jsdoc.js

As far as I can tell, jsdom isn't actually used anymore so this could just be removed. An alternative fix is to rename this to .json. Either would be great and would be an immediate fix to the problem. Obviously the parsers also need to be changed to be less brittle, so I am putting in PRs there too.

Thanks.

@jimthedev
Copy link
Contributor Author

PR submitted. Needs a merge then both can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants