Skip to content

UrlMatcherFactory config options not being respected when instance is created with concat #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinkemp opened this issue Nov 3, 2014 · 1 comment

Comments

@kevinkemp
Copy link

Specifically case sensitivity
View the plunkr.

Here is the edited plunkr with changes to ui router that I made.

The solution I used for the project I'm working on was to expose the getDefaultConfig function publicly so that I could use it when using concat to construct instances of UrlMatcher. Let me know if I've overlooked something as my understanding of the entire project isn't at a level that I deem appropriate to claim that I've fixed the issue without breaking anything. I've never submitted a pull request on a public project so let me know if you would like me to and I can do a little research to figure out what all I need to do to make that happen.

@kevinkemp
Copy link
Author

Closing this issue after I found it was recently resolved: #1420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant