Skip to content

master breaks ie8 #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarkRBM opened this issue Sep 19, 2014 · 4 comments
Closed

master breaks ie8 #1383

MarkRBM opened this issue Sep 19, 2014 · 4 comments
Assignees
Labels
Milestone

Comments

@MarkRBM
Copy link

MarkRBM commented Sep 19, 2014

I am not sure if you are still supporting ie8 or not but on master resolve.js line 44 'var invocableKeys = Object.keys(invocables || {}); throws type error: Object dosn't support this property or method.

I was using master to get a feature that was penned for 0.3 but it looks like you put it in 0.2.11 so I can move to that to fix my problem but just letting you know

@christopherthielen christopherthielen added this to the 0.2.12 milestone Sep 19, 2014
@christopherthielen christopherthielen self-assigned this Sep 19, 2014
@christopherthielen
Copy link
Contributor

thanks

@ilanbiala
Copy link

@christopherthielen Are you guys thinking of moving away from Object.keys? If not, you can just add Mozilla's polyfill, and later on when it makes sense to drop IE8 you can remove it?

@christopherthielen
Copy link
Contributor

As far as I know, this is the only place this was introduced, so we'll just rewrite this one spot.

@ilanbiala
Copy link

@christopherthielen sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants