uiSref should allow transition to state with empty url

[christopherthielen]

see comments in #1319

[christopherthielen]

@nateabele should we change this code to generate a "#" url (or "" in html5mode)?

https://github.com/angular-ui/ui-router/blob/master/src/state.js#L1119

That way we'll return an empty string or hash and the ui-sref will be clickable (nav set to true).

https://github.com/angular-ui/ui-router/blob/master/src/stateDirectives.js#L112

We'll still need the check for preventDefault, but only in html5mode, or actually when the generated href is "".

See PR #1363 ... it's only generating an HREF if the top state has the url: "" (as opposed to no url: at all, or url: undefined)

[christopherthielen]

Here's the updated plunk from #1319

http://plnkr.co/edit/mkIORnnEU1udoTmoX7V0?p=preview

[nateabele]

An empty string still wouldn't work because of https://github.com/angular/angular.js/blob/master/src/ng/directive/a.js#L42 — all nav does is avoid burning extra cycles recalculating things.

Ah, just saw the PR. Looks good, but definitely needs test coverage.

[christopherthielen]

Closed via #1363