Using $urlRouterProvider.when() and $stateChangeSuccess/event.preventDefault() the same time lead to infinite loop

[fubupc]

At first I want to check authorization before state transition. So I use $stateChangeSuccess with e.preventDefault method to intercept transition, sample code:

$rootScope.$on('$stateChangeStart', function(e, toState, toParams, fromState, fromParams) {
        e.preventDefault();

        checkAuthorization().then(function() {
            $state.go(toState, toParams, {notify: false})
                .then(function() {
                    $rootScope.$broadcast('$stateChangeSuccess', toState, toParams, fromState, fromParams);
                 })
        });
})

It works fine until using $urlRouterProvider.when() for some url redirect:

$urlRouterProvider.when('/A', '/A/B');

Now if you visit url /A, then the browser would be trapped into an indefinite loop. I made a simple demo plunker here: http://plnkr.co/edit/lUkJx27HiaaNAJbF07n2?p=preview

Please open console and click 'A' link to see what I mean...

PS: This is an issue relative to #178

[lonormaly]

I wasted days trying to solve the issues revolves around the changeState...

For this issue I figured that if I add this code, it works:

        $rootScope.$on('$locationChangeStart', function (event, next, current) {
            $rootScope.$broadcast('$locationChangeSuccess', next, current);
        });

[fubupc]

@lonormaly Actually I have found a workaround as well: add an $urlRouter.update(true) after e.preventDefault(). sample code:

$rootScope.$on('$stateChangeStart', function(e, toState, toParams, fromState, fromParams) {
        e.preventDefault();

        $urlRouter.update(true); // add this!

        checkAuthorization().then(function() {
            $state.go(toState, toParams, {notify: false})
                .then(function() {
                    $rootScope.$broadcast('$stateChangeSuccess', toState, toParams, fromState, fromParams);
                 })
        });
})

But it has a drawback: if the authorization check failed, the url will not revert back.

[lonormaly]

Worked for me, thanks!

Still a workaround...

[ProLoser]

I tend to just use an authorized state and make the check part of the resolve, then I simply parent it to whatever states I want to require authorization under. Resolves FTW.

[fubupc]

@ProLoser Another approach for authorization. Thanks!

[gergelyhegykozi]

Maybe it can be relevant in this issue: https://github.com/leonuh/ui-router.redirect

[stale]

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.

This does not mean that the issue is invalid. Valid issues
may be reopened.

Thank you for your contributions.