Skip to content

Event when transition to same state is cancelled #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikaspran opened this issue Apr 10, 2014 · 2 comments
Closed

Event when transition to same state is cancelled #1016

nikaspran opened this issue Apr 10, 2014 · 2 comments
Assignees

Comments

@nikaspran
Copy link
Contributor

There is currently a lack of an event to mark the end of the state change when transitioning to the same state. To be exact, the $stateChangeStart event is emitted, but no event signifying the end of the transition (neither $stateChangeSuccess nor $stateChangeError). This makes it impossible to cover all possible transition results via event handling.

To be precise, this code cancels the transition:

      if (shouldTriggerReload(to, from, locals, options) ) {
        if (to.self.reloadOnSearch !== false) $urlRouter.update();
        $state.transition = null;
        return $q.when($state.current);
      }

I'd like to suggest that an event would be sent, something along the lines of $stateChangeCancelled or something of the sort.

@adamschwartz
Copy link

👍

@nateabele
Copy link
Contributor

This is now being tracked in #1257. Please follow that issue for updates. Thanks!

@christopherthielen christopherthielen removed this from the 0.3.0 milestone Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants