Skip to content

Commit f9c3e3c

Browse files
fix(TransitionManager): Update url even when the Transition is ignored.
Closes #2723
1 parent 8742511 commit f9c3e3c

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

src/state/hooks/transitionManager.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,7 @@ export class TransitionManager {
7878
// Handle redirect and abort
7979
if (error instanceof Rejection) {
8080
if (error.type === RejectType.IGNORED) {
81-
// Update $stateParmas/$state.params/$location.url if transition ignored, but dynamic params have changed.
82-
let dynamic = $state.$current.parameters().filter(prop('dynamic'));
83-
if (!Param.equals(dynamic, $state.params, transition.params())) {
84-
this.updateUrl();
85-
}
81+
this.$urlRouter.update();
8682
return $state.current;
8783
}
8884

@@ -104,7 +100,6 @@ export class TransitionManager {
104100
let transition = this.transition;
105101
let {$urlRouter, $state} = this;
106102
let options = transition.options();
107-
var toState = transition.$to();
108103

109104
if (options.location && $state.$current.navigable) {
110105
$urlRouter.push($state.$current.navigable.url, $state.params, { replace: options.location === 'replace' });

0 commit comments

Comments
 (0)