Skip to content

Commit f28e0c3

Browse files
fix(ng2.uiView): Dispose prev comp on empty viewconfig
1 parent b1624c6 commit f28e0c3

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/ng2/uiView.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ const getProviders = (injector) => {
3131
}`
3232
],
3333
template: `<div #content></div>`,
34-
// debugtemplate: `
34+
// template: `
3535
// <div style="padding: 1em; border: 1px solid lightgrey;">
3636
//
3737
// <div #content style="color: lightgrey; font-size: smaller;">
3838
// <div>ui-view #{{uiViewData.id}} created by '{{ parentContext.name || "(root)" }}' state</div>
3939
// <div>name: (absolute) '{{uiViewData.fqn}}' (contextual) '{{uiViewData.name}}@{{parentContext.name}}' </div>
40-
// <div>currently filled by: '{{(uiViewData.config && uiViewData.config.context) || 'empty...'}}'</div>
40+
// <div>currently filled by: '{{(uiViewData.config && uiViewData.config.viewDecl.$context) || 'empty...'}}'</div>
4141
// </div>
4242
//
4343
// </div>`
@@ -90,7 +90,10 @@ export class UiView {
9090
}
9191

9292
viewConfigUpdated(config: ViewConfig) {
93-
if (!config) return; // TODO do something smarter
93+
if (!config) {
94+
return this.disposeLast();
95+
}
96+
9497
let {uiViewData, injector, dcl, elementRef} = this;
9598
let viewDecl = <Ng2ViewDeclaration> config.viewDecl;
9699

0 commit comments

Comments
 (0)