Skip to content

Commit ec1c534

Browse files
fix(view): only run ng1 route-to-component code if component: is a string
1 parent 3fc2012 commit ec1c534

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/ng1/viewDirective.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/** @module ng1_directives */ /** for typedoc */
22
"use strict";
33
import {extend, map, unnestR, filter} from "../common/common";
4-
import {isDefined, isFunction} from "../common/predicates";
4+
import {isDefined, isFunction, isString} from "../common/predicates";
55
import {trace} from "../common/trace";
66
import {ActiveUIView} from "../view/interface";
77
import {Ng1ViewConfig} from "./viewsBuilder";
@@ -357,7 +357,7 @@ function $ViewDirectiveFill ( $compile, $controller, $transitions, $view,
357357
}
358358

359359
// Wait for the component to appear in the DOM
360-
if (cfg.viewDecl.component) {
360+
if (isString(cfg.viewDecl.component)) {
361361
let cmp = cfg.viewDecl.component;
362362
let kebobName = kebobString(cmp);
363363
let getComponentController = () => {

src/ng1/viewsBuilder.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ export function ng1ViewsBuilder(state: State) {
4949
config.templateProvider = ['$injector', function($injector) {
5050
const resolveFor = key => config.bindings && config.bindings[key] || key;
5151
const prefix = angular.version.minor >= 3 ? "::" : "";
52-
let attrs = getComponentInputs($injector, config.component).map(key => `${kebobString(key)}='${prefix}$resolve.${resolveFor(key)}'`).join(" ");
52+
let attrs = getComponentInputs($injector, config.component)
53+
.map(key => `${kebobString(key)}='${prefix}$resolve.${resolveFor(key)}'`).join(" ");
5354
let kebobName = kebobString(config.component);
5455
return `<${kebobName} ${attrs}></${kebobName}>`;
5556
}];

0 commit comments

Comments
 (0)