BREAKING CHANGE: Move imperative $resolve service out of main bundle

The `$resolve` service's `.resolve()` method can be used to perform async dependency injection imperatively.

The code has been moved out of the main angular-ui-router codebase and is now opt-in.
For prebuilt bundle users, add `release/resolveService.js` to your project.
For self-bundlers (e.g., webpack), add `angular-ui-router/lib/resolveService` as an `import` or `require()`.

It's unlikely you use this service.
Its most common usage is with the UI-Bootstrap `$modal` service.

Author: christopherthielen

src/legacy/resolveService.ts

@@ -1,5 +1,6 @@
 /** @module ng1 */ /** */
 import { State, PathNode, ResolveContext, Obj, mapObj, resolvablesBuilder } from "ui-router-core";
+import * as angular from "angular";
 
 /**
  * Implementation of the legacy `$resolve` service for angular 1.
@@ -10,6 +11,14 @@ var $resolve = {
    *
    * This emulates most of the behavior of the ui-router 0.2.x $resolve.resolve() service API.
    *
+  * ### Not bundled by default
+   *
+   * This API is no longer not part of the standard `angular-ui-router` bundle.
+   * For users of the prebuilt bundles, add the `release/resolveService.min.js` UMD bundle.
+   * For bundlers (webpack, browserify, etc), add `angular-ui-router/lib/legacy/resolveService`.
+   *
+   * ---
+   *
    * Given an object `invocables`, where keys are strings and values are injectable functions,
    * injects each function, and waits for the resulting promise to resolve.
    * When all resulting promises are resolved, returns the results as an object.
@@ -58,3 +67,6 @@ var $resolve = {
 
 /** @hidden */
 export const resolveFactory = () => $resolve;
+
+// The old $resolve service
+angular.module('ui.router').factory('$resolve', <any> resolveFactory);

src/services.ts

@@ -19,7 +19,6 @@ import {
     UIRouter, IInjectable, StateParams, TransitionService, StateService, UrlRouterProvider,
     UrlRouter, UrlMatcherFactory, ResolveContext, TypedMap
 } from "ui-router-core";
-import { resolveFactory } from "./legacy/resolveService";
 import { ng1ViewsBuilder, ng1ViewConfigFactory } from "./statebuilders/views";
 import { TemplateFactory } from "./templateFactory";
 import { StateProvider } from "./stateProvider";
@@ -176,9 +175,6 @@ angular.module('ui.router.util').factory('$templateFactory', ['$uiRouter', () =>
 // The $view service
 angular.module('ui.router').factory('$view', () => router.viewService);
 
-// The old $resolve service
-angular.module('ui.router').factory('$resolve', <any> resolveFactory);
-
 // $trace service
 angular.module("ui.router").service("$trace", () => trace);
 watchDigests.$inject = ['$rootScope'];

test/resolveSpec.ts

@@ -8,6 +8,7 @@ import "./util/matchers";
 import { resolvedValue, resolvedError, caught } from './util/testUtilsNg1';
 import { ResolveContext, State, PathNode, omit, pick, extend, forEach } from "../src/index";
 import { Resolvable, services, StateDeclaration } from "ui-router-core";
+import "../src/legacy/resolveService";
 
 let module = angular['mock'].module;
 ///////////////////////////////////////////////

tsconfig.json

@@ -13,6 +13,7 @@
   },
   "files": [
     "src/index.ts",
-    "src/legacy/stateEvents.ts"
+    "src/legacy/stateEvents.ts",
+    "src/legacy/resolveService.ts"
   ]
 }

tsconfig.typedoc.json

@@ -12,6 +12,8 @@
   "files": [
     "src/index.ts",
     "../ui-router-core/src/index.ts",
+    "src/legacy/stateEvents.ts",
+    "src/legacy/resolveService.ts",
     "node_modules/typedoc/node_modules/typescript/lib/lib.es6.d.ts"
   ]
 }