cherry-pick 20d6e24 from 0.2.17

Author: christopherthielen

src/params/type.ts

@@ -22,6 +22,7 @@ function ArrayType(type, mode) {
   // Wraps type (.is/.encode/.decode) functions to operate on each value of an array
   function arrayHandler(callback, allTruthyMode?: boolean) {
     return function handleArray(val) {
+      if (isArray(val) && val.length === 0) return val;
       let arr = arrayWrap(val);
       let result = map(arr, callback);
       return (allTruthyMode === true) ? filter(result, x => !x).length === 0 : arrayUnwrap(result);

src/url/urlMatcher.ts

@@ -279,7 +279,7 @@ export class UrlMatcher {
       let value: (any|any[]) = match[i + 1];
 
       // if the param value matches a pre-replace pair, replace the value before decoding.
-      for (let j = 0; j < param.replace; j++) {
+      for (let j = 0; j < param.replace.length; j++) {
         if (param.replace[j].from === value) value = param.replace[j].to;
       }
       if (value && param.array === true) value = decodePathArray(value);
@@ -381,6 +381,7 @@ export class UrlMatcher {
       if (!isPathParam) {
         if (encoded == null || (isDefaultValue && squash !== false)) return;
         if (!isArray(encoded)) encoded = [<string> encoded];
+        if (encoded.length === 0) return;
 
         encoded = map(<string[]> encoded, encodeURIComponent).join(`&${param.id}=`);
         result += (search ? '&' : '?') + (`${param.id}=${encoded}`);

test/urlMatcherFactorySpec.js

@@ -297,6 +297,8 @@ describe("UrlMatcher", function () {
       expect(m.exec($location.path(), $location.search())).toEqual( { param1: undefined } );
       $location.url("/foo?param1=bar");
       expect(m.exec($location.path(), $location.search())).toEqual( { param1: 'bar' } ); // auto unwrap
+      $location.url("/foo?param1=");
+      expect(m.exec($location.path(), $location.search())).toEqual( { param1: undefined } );
       $location.url("/foo?param1=bar&param1=baz");
       if (angular.isArray($location.search())) // conditional for angular 1.0.8
         expect(m.exec($location.path(), $location.search())).toEqual( { param1: ['bar', 'baz'] } );
@@ -359,6 +361,36 @@ describe("UrlMatcher", function () {
       expect(m.format({ "param1[]": ['bar', 'baz'] })).toBe("/foo?param1[]=bar&param1[]=baz");
     }));
 
+    // Test for issue #2222
+    it("should return default value, if query param is missing.", inject(function($location) {
+      var m = new UrlMatcher('/state?param1&param2&param3&param5', {
+        params: {
+          param1 : 'value1',
+          param2 : {array: true, value: ['value2']},
+          param3 : {array: true, value: []},
+          param5 : {array: true, value: function() {return [];}}
+        }
+      });
+
+      var expected = {
+        "param1": 'value1',
+        "param2": ['value2'],
+        "param3": [],
+        "param5": []
+      };
+
+      // Parse url to get Param.value()
+      var parsed = m.exec("/state");
+      expect(parsed).toEqualData(expected);
+
+      // Pass again through Param.value() for normalization (like transitionTo)
+      var paramDefs = m.parameters();
+      var values = common.map(parsed, function(val, key) {
+        return common.find(paramDefs, function(def) { return def.id === key }).value(val);
+      });
+      expect(values).toEqualData(expected);
+    }));
+
     it("should not be wrapped by ui-router into an array if array: false", inject(function($location) {
       var m = new UrlMatcher('/foo?param1', { params: { param1: { array: false } } });